* linux-next: infiniband tree build failure
@ 2009-04-29 4:01 Stephen Rothwell
2009-04-29 4:04 ` [ofa-general] " Stephen Rothwell
2009-04-29 16:51 ` Roland Dreier
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2009-04-29 4:01 UTC (permalink / raw)
To: Roland Dreier, general; +Cc: linux-next, Stefan Roscher
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
Hi Roland,
Today's linux-next build (powerpc ppc64_defconfig) produced this new
warning:
drivers/infiniband/hw/ehca/hcp_phyp.c: In function 'hcp_galpas_ctor':
drivers/infiniband/hw/ehca/hcp_phyp.c:65: warning: assignment makes integer from pointer without a cast
Caused by commit 2bd93ed8b59d9bf8b918a0fa04be50482906c16b ("IB/ehca:
Remove unnecessary memory operations for userspace queue pairs").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ofa-general] Re: linux-next: infiniband tree build failure
2009-04-29 4:01 linux-next: infiniband tree build failure Stephen Rothwell
@ 2009-04-29 4:04 ` Stephen Rothwell
2009-04-29 16:51 ` Roland Dreier
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2009-04-29 4:04 UTC (permalink / raw)
To: Roland Dreier, general; +Cc: linux-next
[-- Attachment #1.1: Type: text/plain, Size: 178 bytes --]
Hi Roland,
That should have said "warning" not "failure", sorry.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: infiniband tree build failure
2009-04-29 4:01 linux-next: infiniband tree build failure Stephen Rothwell
2009-04-29 4:04 ` [ofa-general] " Stephen Rothwell
@ 2009-04-29 16:51 ` Roland Dreier
2009-04-30 3:22 ` [ofa-general] " Stephen Rothwell
1 sibling, 1 reply; 4+ messages in thread
From: Roland Dreier @ 2009-04-29 16:51 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: general, linux-next, Stefan Roscher
> Today's linux-next build (powerpc ppc64_defconfig) produced this new
> warning:
>
> drivers/infiniband/hw/ehca/hcp_phyp.c: In function 'hcp_galpas_ctor':
> drivers/infiniband/hw/ehca/hcp_phyp.c:65: warning: assignment makes integer from pointer without a cast
>
> Caused by commit 2bd93ed8b59d9bf8b918a0fa04be50482906c16b ("IB/ehca:
> Remove unnecessary memory operations for userspace queue pairs").
Thanks for pointing this out. I rolled the below into the patch in
question, which should fix this.
diff --git a/drivers/infiniband/hw/ehca/hcp_phyp.c b/drivers/infiniband/hw/ehca/hcp_phyp.c
index fc3a245..b3e0e72 100644
--- a/drivers/infiniband/hw/ehca/hcp_phyp.c
+++ b/drivers/infiniband/hw/ehca/hcp_phyp.c
@@ -62,7 +62,7 @@ int hcp_galpas_ctor(struct h_galpas *galpas, int is_user,
if (ret)
return ret;
} else
- galpas->kernel.fw_handle = NULL;
+ galpas->kernel.fw_handle = 0;
galpas->user.fw_handle = paddr_user;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [ofa-general] Re: linux-next: infiniband tree build failure
2009-04-29 16:51 ` Roland Dreier
@ 2009-04-30 3:22 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2009-04-30 3:22 UTC (permalink / raw)
To: Roland Dreier; +Cc: Stefan, linux-next, general
[-- Attachment #1.1: Type: text/plain, Size: 321 bytes --]
Hi Roland,
On Wed, 29 Apr 2009 09:51:47 -0700 Roland Dreier <rdreier@cisco•com> wrote:
>
> Thanks for pointing this out. I rolled the below into the patch in
> question, which should fix this.
Thanks.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-30 3:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-29 4:01 linux-next: infiniband tree build failure Stephen Rothwell
2009-04-29 4:04 ` [ofa-general] " Stephen Rothwell
2009-04-29 16:51 ` Roland Dreier
2009-04-30 3:22 ` [ofa-general] " Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox