public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Neil Brown <neilb@suse•de>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	raz ben yehuda <raziebe@gmail•com>,
	"Martin K. Petersen" <martin.petersen@oracle•com>,
	Jens Axboe <jens.axboe@oracle•com>
Subject: linux-next: md tree build failure
Date: Mon, 25 May 2009 15:33:46 +1000	[thread overview]
Message-ID: <20090525153346.758483fc.sfr@canb.auug.org.au> (raw)

Hi Neil,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/md/raid0.c: In function 'create_strip_zones':
drivers/md/raid0.c:243: error: 'struct request_queue' has no member named 'hardsect_size'

Caused by commit e1defc4ff0cf57aca6c5e3ff99fa503f5943c1f1 ("block: Do
away with the notion of hardsect_size") from the block tree interacting
with commit 131e4477401ae76a9cbe8539e4b7819e04cfba36 ("md: raid0: chunk
size check in raid0_run") from the md tree.

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index b8a0747..0bf275d 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -240,7 +240,7 @@ static int create_strip_zones(mddev_t *mddev)
 	 * now since we have the hard sector sizes, we can make sure
 	 * chunk size is a multiple of that sector size
 	 */
-	if (mddev->chunk_size % mddev->queue->hardsect_size) {
+	if (mddev->chunk_size % queue_logical_block_size(mddev->queue)) {
 		printk(KERN_ERR "%s chunk_size of %d not valid\n",
 		       mdname(mddev),
 		       mddev->chunk_size);

             reply	other threads:[~2009-05-25  5:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-25  5:33 Stephen Rothwell [this message]
2009-05-25  6:15 ` linux-next: md tree build failure Jens Axboe
2009-05-25 11:44   ` Martin K. Petersen
2009-06-01  4:42   ` Stephen Rothwell
2009-06-01  5:13     ` Martin K. Petersen
2009-06-01  5:33       ` NeilBrown
     [not found]         ` <yq1prdm6jn1.fsf@sermon.lab.mkp.net>
2009-06-04  4:06           ` Neil Brown
2009-06-04  4:17             ` Martin K. Petersen
  -- strict thread matches above, loose matches on Subject: below --
2009-03-11  5:27 Stephen Rothwell
2009-03-13  0:45 ` Neil Brown
2009-03-13  2:21   ` Stephen Rothwell
2009-03-10  5:47 Stephen Rothwell
2009-03-10  6:38 ` NeilBrown
2009-03-10  6:48   ` Stephen Rothwell
2008-10-15  9:09 Stephen Rothwell
2008-10-15 10:55 ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090525153346.758483fc.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=jens.axboe@oracle$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=martin.petersen@oracle$(echo .)com \
    --cc=neilb@suse$(echo .)de \
    --cc=raziebe@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox