public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Neil Brown <neilb@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org
Subject: Re: linux-next: md tree build failure
Date: Wed, 15 Oct 2008 21:55:12 +1100	[thread overview]
Message-ID: <18677.52240.178867.615640@notabene.brown> (raw)
In-Reply-To: message from Stephen Rothwell on Wednesday October 15

On Wednesday October 15, sfr@canb•auug.org.au wrote:
> Hi Neil,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/md/raid1.c: In function 'sync_request':
> drivers/md/raid1.c:1759: error: implicit declaration of function 'msleep_interruptible'
> make[3]: *** [drivers/md/raid1.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> drivers/md/raid10.c: In function 'sync_request':
> drivers/md/raid10.c:1749: error: implicit declaration of function 'msleep_interruptible'
> make[3]: *** [drivers/md/raid10.o] Error 1
> drivers/md/md.c: In function 'md_do_sync':
> drivers/md/md.c:5915: error: implicit declaration of function 'msleep'
> 
> Caused by commit 6caa3b0bbdb474647f6bdd8a958ffc46f78d8d58 ("md: Remove
> unnecessary #includes, #defines, and function declarations").  I added
> the following patch.

Thanks.  I had heard of this problem in -mm but as I couldn't
reproduce it I thought it might be -mm specific and held off taking
the patch.
I'll add it to my tree now.

Thanks,
NeilBrown


> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Wed, 15 Oct 2008 20:05:50 +1100
> Subject: [PATCH] md: msleep need include of linux/delay.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
>  drivers/md/md.c     |    1 +
>  drivers/md/raid1.c  |    1 +
>  drivers/md/raid10.c |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 4c89836..abc82f2 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -45,6 +45,7 @@
>  #include <linux/random.h>
>  #include <linux/reboot.h>
>  #include <linux/file.h>
> +#include <linux/delay.h>
>  
>  #define MAJOR_NR MD_MAJOR
>  
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index b976442..9c788e2 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -32,6 +32,7 @@
>   */
>  
>  #include "dm-bio-list.h"
> +#include <linux/delay.h>
>  #include <linux/raid/raid1.h>
>  #include <linux/raid/bitmap.h>
>  
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 8bdc9bf..7d7f345 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -19,6 +19,7 @@
>   */
>  
>  #include "dm-bio-list.h"
> +#include <linux/delay.h>
>  #include <linux/raid/raid10.h>
>  #include <linux/raid/bitmap.h>
>  
> -- 
> 1.5.6.5

next prev parent reply	other threads:[~2008-10-15 10:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15  9:09 linux-next: md tree build failure Stephen Rothwell
2008-10-15 10:55 ` Neil Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-03-10  5:47 Stephen Rothwell
2009-03-10  6:38 ` NeilBrown
2009-03-10  6:48   ` Stephen Rothwell
2009-03-11  5:27 Stephen Rothwell
2009-03-13  0:45 ` Neil Brown
2009-03-13  2:21   ` Stephen Rothwell
2009-05-25  5:33 Stephen Rothwell
2009-05-25  6:15 ` Jens Axboe
2009-05-25 11:44   ` Martin K. Petersen
2009-06-01  4:42   ` Stephen Rothwell
2009-06-01  5:13     ` Martin K. Petersen
2009-06-01  5:33       ` NeilBrown
     [not found]         ` <yq1prdm6jn1.fsf@sermon.lab.mkp.net>
2009-06-04  4:06           ` Neil Brown
2009-06-04  4:17             ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18677.52240.178867.615640@notabene.brown \
    --to=neilb@suse$(echo .)de \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox