From: Subrata Modak <subrata@linux•vnet.ibm.com>
To: linux-usb@vger•kernel.org, David Brownell <david-b@pacbell•net>,
David Brownell <dbrownell@users•sourceforge.net>,
Arnd Bergmann <arnd@arndb•de>
Cc: Sachin P Sant <sachinp@linux•vnet.ibm.com>,
Kumar Gala <galak@kernel•crashing.org>,
Linux-Kernel <linux-kernel@vger•kernel.org>,
Randy Dunlap <randy.dunlap@oracle•com>,
Linux-Next <linux-next@vger•kernel.org>,
Jon Smirl <jonsmirl@gmail•com>,
Linuxppc-dev <Linuxppc-dev@ozlabs•org>,
Roman Weissgaerber <weissg@vienna•at>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Subrata Modak <subrata@linux•vnet.ibm.com>,
kernel@wantstofly•org
Subject: Re: [BUILD FAILURE 02/04] Next June 04:PPC64 randconfig [drivers/usb/host/ohci-hcd.o]
Date: Fri, 05 Jun 2009 13:26:51 -0500 [thread overview]
Message-ID: <20090605182651.24094.36577.sendpatchset@elm3a191.beaverton.ibm.com> (raw)
>On Thu, 2009-06-04 at 10:07 -0400, Jon Smirl wrote:
>On Thu, Jun 4, 2009 at 9:31 AM, Subrata Modak
> <subrata@linux•vnet.ibm.com> wrote:
> > CC drivers/usb/host/ohci-hcd.o
> > In file included from drivers/usb/host/ohci-hcd.c:1060:
> > drivers/usb/host/ohci-ppc-of.c:242:2: error: #error "No endianess selected for ppc-of-ohci"
> > make[3]: *** [drivers/usb/host/ohci-hcd.o] Error 1
> > make[2]: *** [drivers/usb/host] Error 2
> > make[1]: *** [drivers/usb] Error 2
> > make: *** [drivers] Error 2
> >
> > I reported this earlier, and there were some discussions:
> > http://groups.google.co.kr/group/linux.kernel/browse_thread/thread/edff9d5572d3d225
>
> Proposed patch by Arnd should fix this. It has not been merged.
> http://lkml.org/lkml/2009/4/22/49
Correct, it fixes the issue. However, since few changes might have gone
to the Kconfig, the patch does not apply cleanly. Below is the patch, just
a retake of the earlier one, but on the latest code.
David,
Can you please pickup the following patch ?
Signed-off-by: Arnd Bergmann <arnd@arndb•de>,
Resent-by: Subrata Modak <subrata@linux•vnet.ibm.com>
---
--- linux-2.6.30-rc8/drivers/usb/host/Kconfig.orig 2009-06-05 10:31:30.000000000 -0500
+++ linux-2.6.30-rc8/drivers/usb/host/Kconfig 2009-06-05 10:37:53.000000000 -0500
@@ -181,26 +181,26 @@ config USB_OHCI_HCD_PPC_SOC
Enables support for the USB controller on the MPC52xx or
STB03xxx processor chip. If unsure, say Y.
-config USB_OHCI_HCD_PPC_OF
- bool "OHCI support for PPC USB controller on OF platform bus"
- depends on USB_OHCI_HCD && PPC_OF
- default y
- ---help---
- Enables support for the USB controller PowerPC present on the
- OpenFirmware platform bus.
-
config USB_OHCI_HCD_PPC_OF_BE
- bool "Support big endian HC"
- depends on USB_OHCI_HCD_PPC_OF
- default y
+ bool "OHCI support for OF platform bus (big endian)"
+ depends on USB_OHCI_HCD && PPC_OF
select USB_OHCI_BIG_ENDIAN_DESC
select USB_OHCI_BIG_ENDIAN_MMIO
+ ---help---
+ Enables support for big-endian USB controllers present on the
+ OpenFirmware platform bus.
config USB_OHCI_HCD_PPC_OF_LE
- bool "Support little endian HC"
- depends on USB_OHCI_HCD_PPC_OF
- default n
+ bool "OHCI support for OF platform bus (little endian)"
+ depends on USB_OHCI_HCD && PPC_OF
select USB_OHCI_LITTLE_ENDIAN
+ ---help---
+ Enables support for little-endian USB controllers present on the
+ OpenFirmware platform bus.
+
+ config USB_OHCI_HCD_PPC_OF
+ bool
+ default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE
config USB_OHCI_HCD_PCI
bool "OHCI support for PCI-bus USB controllers"
---
Regards--
Subrata
>
next reply other threads:[~2009-06-05 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 18:26 Subrata Modak [this message]
[not found] ` <20090605182651.24094.36577.sendpatchset-yA/sI1izFwLkOmf+N4b0O9FgqiXiwxn+0E9HWUfgJXw@public.gmane.org>
2009-06-09 18:36 ` [BUILD FAILURE 02/04] Next June 04:PPC64 randconfig [drivers/usb/host/ohci-hcd.o] Subrata Modak
2009-06-10 0:38 ` David Brownell
[not found] ` <200906091738.58154.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-06-12 9:35 ` Subrata Modak
[not found] ` <1244799348.5234.13.camel-NRFfyExJdYpgXGGE5LP+UZlqa2bBAFbm0E9HWUfgJXw@public.gmane.org>
2009-06-15 6:51 ` Subrata Modak
2009-06-17 12:53 ` Subrata Modak
2009-06-17 18:15 ` Grant Likely
2009-06-17 20:06 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2009-06-04 13:31 Subrata Modak
2009-06-04 14:07 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605182651.24094.36577.sendpatchset@elm3a191.beaverton.ibm.com \
--to=subrata@linux$(echo .)vnet.ibm.com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=david-b@pacbell$(echo .)net \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=galak@kernel$(echo .)crashing.org \
--cc=jonsmirl@gmail$(echo .)com \
--cc=kernel@wantstofly$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sachinp@linux$(echo .)vnet.ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=weissg@vienna$(echo .)at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox