From: Jeff Layton <jlayton@redhat•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Steve French <smfrench@gmail•com>,
linux-cifs-client@lists•samba.org, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: linux-next: cifs tree build failure
Date: Mon, 15 Jun 2009 06:46:18 -0400 [thread overview]
Message-ID: <20090615064618.120a2337@tlielax.poochiereds.net> (raw)
In-Reply-To: <20090615133222.7405743c.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On Mon, 15 Jun 2009 13:32:22 +1000
Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi Steve,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> fs/cifs/cifsfs.c: In function 'cifs_show_options':
> fs/cifs/cifsfs.c:357: error: implicit declaration of function 'cifs_show_address'
>
> Caused by commit 8616e0fc1e27295316f9821a883f0e9fa6f8200f ("cifs: remove
> unneeded NULL checks from cifs_show_options").
>
> I have used the cifs tree from next-20090612 for today.
My fault. That function gets introduced in a later patch and I had a
bogus call left in here from when I reorganized the series. This
patch should fix it and a typo that got silently fixed in a patch that
hasn't been committed yet.
This patch should fix both. Steve F., let me know if you want me to
respin the series on top of this patch. Note that there's still a
harmless compiler warning that gets fixed in a later patch in the
series.
Thanks,
--
Jeff Layton <jlayton@redhat•com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-cifs-fix-problems-with-earlier-patches.patch --]
[-- Type: text/x-patch, Size: 1466 bytes --]
From c5949e669f4a85c16b3529777f5d550bddea9dd9 Mon Sep 17 00:00:00 2001
From: Jeff Layton <jlayton@redhat•com>
Date: Mon, 15 Jun 2009 06:40:23 -0400
Subject: [PATCH] cifs: fix problems with earlier patches
cifs_show_address hasn't been introduced yet, and fix a typo that was
silently fixed by a later patch in the series.
Signed-off-by: Jeff Layton <jlayton@redhat•com>
---
fs/cifs/cifsfs.c | 2 --
fs/cifs/netmisc.c | 2 +-
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 8b31570..4b8ec25 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -354,8 +354,6 @@ cifs_show_options(struct seq_file *s, struct vfsmount *m)
if (tcon->ses->domainName)
seq_printf(s, ",domain=%s", tcon->ses->domainName);
- cifs_show_address(s, tcon->ses->server);
-
seq_printf(s, ",uid=%d", cifs_sb->mnt_uid);
if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_UID)
seq_printf(s, ",forceuid");
diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
index 00e6e35..f9a54da 100644
--- a/fs/cifs/netmisc.c
+++ b/fs/cifs/netmisc.c
@@ -166,7 +166,7 @@ int
cifs_convert_address(char *src, void *dst)
{
struct sockaddr_in *s4 = (struct sockaddr_in *) dst;
- struct sockaddr_in6 *s6 = (Struct sockaddr_in6 *) dst;
+ struct sockaddr_in6 *s6 = (struct sockaddr_in6 *) dst;
if (cifs_inet_pton(AF_INET, src, &s4->sin_addr.s_addr)) {
s4->sin_family = AF_INET;
--
1.6.0.6
next prev parent reply other threads:[~2009-06-15 10:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 3:32 linux-next: cifs tree build failure Stephen Rothwell
2009-06-15 10:46 ` Jeff Layton [this message]
2009-06-15 13:47 ` Steve French
-- strict thread matches above, loose matches on Subject: below --
2009-04-14 1:41 Stephen Rothwell
2009-04-15 2:59 ` Stephen Rothwell
2009-04-15 3:10 ` Steve French
2009-04-15 3:20 ` Stephen Rothwell
2009-04-03 3:31 Steve French
2009-04-03 2:07 Stephen Rothwell
2009-02-24 6:56 Stephen Rothwell
2009-02-24 14:45 ` Steve French
2009-02-25 3:03 ` Stephen Rothwell
2008-12-02 2:23 Stephen Rothwell
2008-12-03 2:53 ` Stephen Rothwell
2008-12-03 3:19 ` David Miller
2008-12-03 11:57 ` Jeff Layton
2008-12-03 20:40 ` David Miller
2008-12-12 3:32 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615064618.120a2337@tlielax.poochiereds.net \
--to=jlayton@redhat$(echo .)com \
--cc=linux-cifs-client@lists$(echo .)samba.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=smfrench@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox