From: Steve French <smfrench@gmail•com>
To: Jeff Layton <jlayton@redhat•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-cifs-client@lists•samba.org,
linux-kernel@vger•kernel.org
Subject: Re: linux-next: cifs tree build failure
Date: Mon, 15 Jun 2009 08:47:12 -0500 [thread overview]
Message-ID: <524f69650906150647y15f4b6e2w3ce2df97064fb95b@mail.gmail.com> (raw)
In-Reply-To: <20090615064618.120a2337@tlielax.poochiereds.net>
Jeff,
I just applied and reviewed your patch 5 (thus modified your patch
slightly before merging).
https://mail.google.com/mail/?shva=1#search/cifs_show_address/121cfb7757cb8e86
On Mon, Jun 15, 2009 at 5:46 AM, Jeff Layton<jlayton@redhat•com> wrote:
> On Mon, 15 Jun 2009 13:32:22 +1000
> Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
>> Hi Steve,
>>
>> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>>
>> fs/cifs/cifsfs.c: In function 'cifs_show_options':
>> fs/cifs/cifsfs.c:357: error: implicit declaration of function 'cifs_show_address'
>>
>> Caused by commit 8616e0fc1e27295316f9821a883f0e9fa6f8200f ("cifs: remove
>> unneeded NULL checks from cifs_show_options").
>>
>> I have used the cifs tree from next-20090612 for today.
>
> My fault. That function gets introduced in a later patch and I had a
> bogus call left in here from when I reorganized the series. This
> patch should fix it and a typo that got silently fixed in a patch that
> hasn't been committed yet.
>
> This patch should fix both. Steve F., let me know if you want me to
> respin the series on top of this patch. Note that there's still a
> harmless compiler warning that gets fixed in a later patch in the
> series.
>
> Thanks,
> --
> Jeff Layton <jlayton@redhat•com>
>
--
Thanks,
Steve
next prev parent reply other threads:[~2009-06-15 13:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 3:32 linux-next: cifs tree build failure Stephen Rothwell
2009-06-15 10:46 ` Jeff Layton
2009-06-15 13:47 ` Steve French [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-14 1:41 Stephen Rothwell
2009-04-15 2:59 ` Stephen Rothwell
2009-04-15 3:10 ` Steve French
2009-04-15 3:20 ` Stephen Rothwell
2009-04-03 3:31 Steve French
2009-04-03 2:07 Stephen Rothwell
2009-02-24 6:56 Stephen Rothwell
2009-02-24 14:45 ` Steve French
2009-02-25 3:03 ` Stephen Rothwell
2008-12-02 2:23 Stephen Rothwell
2008-12-03 2:53 ` Stephen Rothwell
2008-12-03 3:19 ` David Miller
2008-12-03 11:57 ` Jeff Layton
2008-12-03 20:40 ` David Miller
2008-12-12 3:32 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524f69650906150647y15f4b6e2w3ce2df97064fb95b@mail.gmail.com \
--to=smfrench@gmail$(echo .)com \
--cc=jlayton@redhat$(echo .)com \
--cc=linux-cifs-client@lists$(echo .)samba.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox