From: "Rafael J. Wysocki" <rjw@sisk•pl>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
pm list <linux-pm@lists•linux-foundation.org>,
Alan Stern <stern@rowland•harvard.edu>,
Mauro Carvalho Chehab <mchehab@infradead•org>,
linux-media@vger•kernel.org
Subject: Re: linux-next: suspend tree build warnings
Date: Wed, 19 Aug 2009 23:38:03 +0200 [thread overview]
Message-ID: <200908192338.03910.rjw@sisk.pl> (raw)
In-Reply-To: <20090819172419.2cf53008.sfr@canb.auug.org.au>
On Wednesday 19 August 2009, Stephen Rothwell wrote:
> Hi Rafael,
Hi,
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
>
> drivers/media/dvb/frontends/dib7000p.c: In function ‘dib7000p_i2c_enumeration’:
> drivers/media/dvb/frontends/dib7000p.c:1315: warning: the frame size of 2256 bytes is larger than 2048 bytes
> drivers/media/dvb/frontends/dib3000mc.c: In function ‘dib3000mc_i2c_enumeration’:
> drivers/media/dvb/frontends/dib3000mc.c:853: warning: the frame size of 2160 bytes is larger than 2048 bytes
>
> Introduced by commit 99307958cc9c1b0b2e0dad4bbefdafaf9ac5a681 ("PM:
> Introduce core framework for run-time PM of I/O devices (rev. 17)").
Well.
This commit increases the size of struct device quite a bit and both of the
drivers above create a "state" object on the stack that contains struct device
among other things.
I think they should allocate these objects using kmalloc() and I don't know
what I can do about this, really. Maybe except for modifying the drivers to
use kmalloc().
Thanks,
Rafael
next prev parent reply other threads:[~2009-08-19 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 7:24 linux-next: suspend tree build warnings Stephen Rothwell
2009-08-19 21:38 ` Rafael J. Wysocki [this message]
2009-08-19 23:36 ` Greg KH
2009-08-20 0:44 ` Andy Walls
2009-08-20 7:01 ` Patrick Boettcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908192338.03910.rjw@sisk.pl \
--to=rjw@sisk$(echo .)pl \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pm@lists$(echo .)linux-foundation.org \
--cc=mchehab@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox