From: Patrick Boettcher <pboettcher@kernellabs•com>
To: Andy Walls <awalls@radix•net>
Cc: Greg KH <greg@kroah•com>, "Rafael J. Wysocki" <rjw@sisk•pl>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
pm list <linux-pm@lists•linux-foundation.org>,
Alan Stern <stern@rowland•harvard.edu>,
Mauro Carvalho Chehab <mchehab@infradead•org>,
linux-media@vger•kernel.org
Subject: Re: linux-next: suspend tree build warnings
Date: Thu, 20 Aug 2009 09:01:44 +0200 (CEST) [thread overview]
Message-ID: <alpine.LRH.1.10.0908200859060.7249@pub3.ifh.de> (raw)
In-Reply-To: <1250729056.2716.37.camel@morgan.walls.org>
Hi,
On Wed, 19 Aug 2009, Andy Walls wrote:
>> Ick. struct device should _never_ be on the stack, why would this code
>> want to do such a thing?
When you are doing a thing it does not necessarily you know that you're
doing it.
> It appears that the state object is a dummy being used to detect and
> twiddle some identical chips on the i2c bus. The functions called only
> use the "i2c_adapter" and "cfg" member of the dummy state object, but
> those functions want that state object as an input argument.
>
> <obvious>
> The simplest fix is dynamic allocation of the dummy state object with
> kmalloc() and then to free it before exiting the function.
> </obvious>
Even more obvious: Fix the function with simpler code to do the same
thing.
I will try to fetch some time from somewhere to work on it.
--
Patrick
http://www.kernellabs.com/
prev parent reply other threads:[~2009-08-20 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 7:24 linux-next: suspend tree build warnings Stephen Rothwell
2009-08-19 21:38 ` Rafael J. Wysocki
2009-08-19 23:36 ` Greg KH
2009-08-20 0:44 ` Andy Walls
2009-08-20 7:01 ` Patrick Boettcher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.1.10.0908200859060.7249@pub3.ifh.de \
--to=pboettcher@kernellabs$(echo .)com \
--cc=awalls@radix$(echo .)net \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pm@lists$(echo .)linux-foundation.org \
--cc=mchehab@infradead$(echo .)org \
--cc=rjw@sisk$(echo .)pl \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox