From: Stephen Rothwell <sfr@canb•auug.org.au>
To: "Rafael J. Wysocki" <rjw@sisk•pl>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Stephen Hemminger <shemminger@vyatta•com>
Subject: Re: linux-next: suspend tree build failure
Date: Wed, 7 Oct 2009 15:29:14 +1100 [thread overview]
Message-ID: <20091007152914.8dadf6d7.sfr@canb.auug.org.au> (raw)
In-Reply-To: <200910070031.55135.rjw@sisk.pl>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
Hi Rafael,
On Wed, 7 Oct 2009 00:31:55 +0200 "Rafael J. Wysocki" <rjw@sisk•pl> wrote:
>
> Thanks for the notification.
>
> Did you cross-compile it by chance? It builds for me on native x86_64 with
> allmodconfig, which is why I missed this issue.
I cross compile all my x86 builds as my big machines are all PowerPC.
> > I have used the version of the suspend tree from next-20091002 for today.
>
> I added the #include <linux/compiler.h> to freezer.h, but obviously I couldn't
> verify if that fixed the problem. Hopefully it did.
My guess was wrong. You either need to leave the __cold off the
definition in kernel/freezer.c or move it before the function name. No
other function definition in the kernel is marked __cold, but several
declarations are.
Also __cold only generates something for gcc >= 4.3 ... I am using 4.4.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-10-07 4:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 2:55 linux-next: suspend tree build failure Stephen Rothwell
2009-10-06 22:31 ` Rafael J. Wysocki
2009-10-07 4:29 ` Stephen Rothwell [this message]
2009-10-07 20:41 ` Rafael J. Wysocki
2009-10-07 23:48 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-10-12 3:00 Stephen Rothwell
2009-10-12 22:44 ` Rafael J. Wysocki
2009-10-13 0:58 ` Stephen Rothwell
2009-10-08 4:30 Stephen Rothwell
2009-10-05 5:00 Stephen Rothwell
2009-10-05 23:55 ` Rafael J. Wysocki
2009-10-06 2:39 ` Stephen Rothwell
2009-08-18 8:30 Stephen Rothwell
2009-08-18 21:43 ` Rafael J. Wysocki
2009-08-18 22:13 ` Paul Mundt
2009-08-18 22:40 ` Rafael J. Wysocki
2009-08-18 22:47 ` Paul Mundt
2009-08-18 23:57 ` Stephen Rothwell
2009-08-17 8:40 Stephen Rothwell
2009-08-17 12:06 ` Rafael J. Wysocki
2009-03-16 9:13 Stephen Rothwell
2009-03-16 22:07 ` Rafael J. Wysocki
2009-03-16 23:09 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007152914.8dadf6d7.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rjw@sisk$(echo .)pl \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox