From: Bjorn Helgaas <bjorn.helgaas@hp•com>
To: Sachin Sant <sachinp@in•ibm.com>
Cc: LKML <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org, jbarnes@virtuousgeek•org
Subject: Re: linux-next: Tree for November 5
Date: Thu, 5 Nov 2009 11:17:11 -0600 [thread overview]
Message-ID: <200911051017.12135.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200911050931.04838.bjorn.helgaas@hp.com>
On Thursday 05 November 2009 09:31:04 am Bjorn Helgaas wrote:
> On Thursday 05 November 2009 03:38:27 am Sachin Sant wrote:
> > Today's next tree fails to build on i386 with
> >
> > arch/x86/pci/built-in.o: In function `align_resource':
> > arch/x86/pci/acpi.c:82: undefined reference to `__udivdi3'
> >
> > The code in question was added by commit
> > 03db42adfeeabe856dbb6894dd3aaff55838330a.
>
> I'll look into this. I did build and test a 32-bit x86 kernel, but
> I built it on an x86_64 box using "linux32 make ...", which looks like
> it used gcc 4.3.2.
Can you try the patch below, please?
commit 00f16f0a2f4826eadec0565e4b454ab8bc7824cc
Author: Bjorn Helgaas <bjorn.helgaas@hp•com>
Date: Thu Nov 5 10:03:57 2009 -0700
x86/PCI: remove 64-bit division
The roundup() caused a build error (undefined reference to `__udivdi3').
We're aligning to power-of-two boundaries, so it's simpler to just use
ALIGN() anyway, which avoids the division.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp•com>
diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
index 8ddf4f4..959e548 100644
--- a/arch/x86/pci/acpi.c
+++ b/arch/x86/pci/acpi.c
@@ -69,17 +69,17 @@ align_resource(struct acpi_device *bridge, struct resource *res)
* that claim this address space have starting alignment and length
* constraints, so fix any obvious BIOS goofs.
*/
- if (res->start & (align - 1)) {
+ if (!IS_ALIGNED(res->start, align)) {
dev_printk(KERN_DEBUG, &bridge->dev,
"host bridge window %pR invalid; "
"aligning start to %d-byte boundary\n", res, align);
res->start &= ~(align - 1);
}
- if ((res->end + 1) & (align - 1)) {
+ if (!IS_ALIGNED(res->end + 1, align)) {
dev_printk(KERN_DEBUG, &bridge->dev,
"host bridge window %pR invalid; "
"aligning end to %d-byte boundary\n", res, align);
- res->end = roundup(res->end, align) - 1;
+ res->end = ALIGN(res->end, align) - 1;
}
}
next prev parent reply other threads:[~2009-11-05 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 8:04 linux-next: Tree for November 5 Stephen Rothwell
2009-11-05 10:38 ` Sachin Sant
2009-11-05 16:31 ` Bjorn Helgaas
2009-11-05 17:17 ` Bjorn Helgaas [this message]
2009-11-06 15:56 ` Bjorn Helgaas
2009-11-07 16:57 ` Sachin Sant
2009-11-06 17:53 ` Randy Dunlap
2009-11-06 22:00 ` Jesse Barnes
2009-11-05 17:22 ` [PATCH -next] sound: hda, move hp_bseries_system Randy Dunlap
2009-11-05 17:32 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2008-11-05 7:43 linux-next: Tree for November 5 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911051017.12135.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp$(echo .)com \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sachinp@in$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox