From: Takashi Iwai <tiwai@suse•de>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Jaroslav Kysela <perex@perex•cz>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH -next] sound: hda, move hp_bseries_system
Date: Thu, 05 Nov 2009 18:32:14 +0100 [thread overview]
Message-ID: <s5h1vkclvxd.wl%tiwai@suse.de> (raw)
In-Reply-To: <20091105092230.7765af8c.randy.dunlap@oracle.com>
At Thu, 5 Nov 2009 09:22:30 -0800,
Randy Dunlap wrote:
>
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> Function hp_bseries_system() is always used, outside of
> CONFIG_ boundaries/controls, so move it.
>
> sound/pci/hda/patch_sigmatel.c:5458: error: implicit declaration of function 'hp_bseries_system'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
Applied now. Thanks!
Takashi
> ---
> sound/pci/hda/patch_sigmatel.c | 40 +++++++++++++++----------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> --- linux-next-20091105.orig/sound/pci/hda/patch_sigmatel.c
> +++ linux-next-20091105/sound/pci/hda/patch_sigmatel.c
> @@ -4668,6 +4668,26 @@ static void stac92xx_unsol_event(struct
> }
> }
>
> +static int hp_bseries_system(u32 subsystem_id)
> +{
> + switch (subsystem_id) {
> + case 0x103c307e:
> + case 0x103c307f:
> + case 0x103c3080:
> + case 0x103c3081:
> + case 0x103c1722:
> + case 0x103c1723:
> + case 0x103c1724:
> + case 0x103c1725:
> + case 0x103c1726:
> + case 0x103c1727:
> + case 0x103c1728:
> + case 0x103c1729:
> + return 1;
> + }
> + return 0;
> +}
> +
> #ifdef CONFIG_PROC_FS
> static void stac92hd_proc_hook(struct snd_info_buffer *buffer,
> struct hda_codec *codec, hda_nid_t nid)
> @@ -4733,26 +4753,6 @@ static int stac92xx_resume(struct hda_co
> return 0;
> }
>
> -static int hp_bseries_system(u32 subsystem_id)
> -{
> - switch (subsystem_id) {
> - case 0x103c307e:
> - case 0x103c307f:
> - case 0x103c3080:
> - case 0x103c3081:
> - case 0x103c1722:
> - case 0x103c1723:
> - case 0x103c1724:
> - case 0x103c1725:
> - case 0x103c1726:
> - case 0x103c1727:
> - case 0x103c1728:
> - case 0x103c1729:
> - return 1;
> - }
> - return 0;
> -}
> -
> /*
> * using power check for controlling mute led of HP notebooks
> * check for mute state only on Speakers (nid = 0x10)
>
prev parent reply other threads:[~2009-11-05 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 8:04 linux-next: Tree for November 5 Stephen Rothwell
2009-11-05 10:38 ` Sachin Sant
2009-11-05 16:31 ` Bjorn Helgaas
2009-11-05 17:17 ` Bjorn Helgaas
2009-11-06 15:56 ` Bjorn Helgaas
2009-11-07 16:57 ` Sachin Sant
2009-11-06 17:53 ` Randy Dunlap
2009-11-06 22:00 ` Jesse Barnes
2009-11-05 17:22 ` [PATCH -next] sound: hda, move hp_bseries_system Randy Dunlap
2009-11-05 17:32 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1vkclvxd.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=perex@perex$(echo .)cz \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox