From: Konrad Rzeszutek Wilk <konrad@kernel•org>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Linux-Kernel <linux-kernel@vger•kernel.org>,
Peter Jones <pjones@redhat•com>,
Konrad Rzeszutek Wilk <konrad@kernel•org>,
linux-next@vger•kernel.org
Subject: Re: linux-next: April 27 (iscsi_ibft)
Date: Tue, 27 Apr 2010 19:01:21 -0400 [thread overview]
Message-ID: <20100427230121.GA31743@andromeda.dapyr.net> (raw)
In-Reply-To: <80edf231-ef31-4f21-ab1b-1a21fda35809@default>
On Tue, Apr 27, 2010 at 09:13:16AM -0700, Randy Dunlap wrote:
> when CONFIG_ACPI is not enabled:
>
> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
Yikes.
Randy, thank you for spotting this and sending an e-mail my way.
It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which
is gone when !CONFIG_ACPI.
Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included
a copy of the old ibft_struct that should work.
Or we make the code dependent on CONFIG_ACPI (in the Kconfig
file).
Peter, Randy: Which option do you think makes more sense?
next prev parent reply other threads:[~2010-04-27 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 16:13 linux-next: April 27 (iscsi_ibft) Randy Dunlap
2010-04-27 23:01 ` Konrad Rzeszutek Wilk [this message]
2010-04-28 15:26 ` Randy Dunlap
2010-05-11 17:58 ` Konrad Rzeszutek Wilk
2010-05-03 16:01 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427230121.GA31743@andromeda.dapyr.net \
--to=konrad@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=pjones@redhat$(echo .)com \
--cc=randy.dunlap@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox