public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	lud <linux-usb@vger•kernel.org>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	David Brownell <dbrownell@users•sourceforge.net>,
	gregkh@suse•de
Subject: Re: [PATCH -next] usb gadget webcam: depends on VIDEO_DEV
Date: Thu, 6 May 2010 09:57:13 +0200	[thread overview]
Message-ID: <201005060957.13833.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20100505154626.2c036f1d.randy.dunlap@oracle.com>

Hi Randy,

On Thursday 06 May 2010 00:46:26 Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle•com>
> 
> g_webcam uses v4l[2] interfaces, so it should depend on VIDEO_DEV.
> 
> ERROR: "v4l2_event_unsubscribe" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_event_queue" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "video_device_release" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "video_usercopy" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_event_dequeue" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "video_register_device" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "video_device_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_event_subscribe" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "video_unregister_device" [drivers/usb/gadget/g_webcam.ko] ndefined!
> ERROR: "v4l2_event_pending" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_fh_init" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "video_devdata" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_event_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_fh_add" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_fh_del" [drivers/usb/gadget/g_webcam.ko] undefined!
> ERROR: "v4l2_fh_exit" [drivers/usb/gadget/g_webcam.ko] undefined!

Oops, my bad. Thanks for the patch.

> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard•com>

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2010-05-06  7:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05  2:34 linux-next: Tree for May 5 Stephen Rothwell
2010-05-05 22:44 ` [PATCH -next] media: fix vivi build error Randy Dunlap
2010-05-05 22:45 ` [PATCH -next] staging/rar_register: depends on PCI Randy Dunlap
2010-05-05 23:55   ` Alan Cox
2010-05-06  2:32     ` Randy Dunlap
2010-05-05 22:46 ` [PATCH -next] usb gadget webcam: depends on VIDEO_DEV Randy Dunlap
2010-05-06  7:57   ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005060957.13833.laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard$(echo .)com \
    --cc=dbrownell@users$(echo .)sourceforge.net \
    --cc=gregkh@suse$(echo .)de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-usb@vger$(echo .)kernel.org \
    --cc=randy.dunlap@oracle$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox