From: Alan Cox <alan@lxorguk•ukuu.org.uk>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
gregkh@suse•de, linux-next@vger•kernel.org,
LKML <linux-kernel@vger•kernel.org>,
devel@driverdev•osuosl.org
Subject: Re: [PATCH -next] staging/rar_register: depends on PCI
Date: Thu, 6 May 2010 00:55:57 +0100 [thread overview]
Message-ID: <20100506005557.7d458c7b@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20100505154522.c3d7807c.randy.dunlap@oracle.com>
On Wed, 5 May 2010 15:45:22 -0700
Randy Dunlap <randy.dunlap@oracle•com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> rar_register driver uses PCI interfaces and PCI devices, so it
> should depend on PCI.
>
> Also format the Kconfig help text as normally done.
>
> drivers/staging/rar_register/rar_register.c:623: error: implicit declaration of function 'pci_dev_get'
> drivers/staging/rar_register/rar_register.c:623: warning: assignment makes pointer from integer without a cast
>
> Note: The memrar driver selects this driver's Kconfig symbol, even when
> PCI is not enabled. That select could be changed to
> select RAR_REGISTER if PCI
> but that would still result in build errors when PCI is not enabled, namely:
> drivers/built-in.o: In function `memrar_fini_rar_resources':
> memrar_handler.c:(.text+0x2391b7): undefined reference to `unregister_rar'
> drivers/built-in.o: In function `memrar_registration_callback':
> memrar_handler.c:(.text+0x23925a): undefined reference to `rar_get_address'
> drivers/built-in.o: In function `memrar_init':
> memrar_handler.c:(.init.text+0x12c7b): undefined reference to `register_rar'
> memrar_handler.c:(.init.text+0x12c97): undefined reference to `register_rar'
>
> Does anyone have suggestions for this?
Yes - memrar should depend upon the RAR_REGISTER
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
Acked-by: Alan Cox <alan@linux•intel.com>
next prev parent reply other threads:[~2010-05-05 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 2:34 linux-next: Tree for May 5 Stephen Rothwell
2010-05-05 22:44 ` [PATCH -next] media: fix vivi build error Randy Dunlap
2010-05-05 22:45 ` [PATCH -next] staging/rar_register: depends on PCI Randy Dunlap
2010-05-05 23:55 ` Alan Cox [this message]
2010-05-06 2:32 ` Randy Dunlap
2010-05-05 22:46 ` [PATCH -next] usb gadget webcam: depends on VIDEO_DEV Randy Dunlap
2010-05-06 7:57 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506005557.7d458c7b@lxorguk.ukuu.org.uk \
--to=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox