public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
	John Johansen <john.johansen@canonical•com>
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	James Morris <jmorris@namei•org>,
	linux-security-module@vger•kernel.org
Subject: [PATCH -next] apparmor: depends on NET
Date: Mon, 2 Aug 2010 10:52:18 -0700	[thread overview]
Message-ID: <20100802105218.c2050fff.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20100802144432.70293bda.sfr@canb.auug.org.au>

From: Randy Dunlap <randy.dunlap@oracle•com>

SECURITY_APPARMOR should depend on NET since AUDIT needs
(depends on) NET.

Fixes 70-80 errors that occur when CONFIG_NET is not enabled,
but APPARMOR selects AUDIT without qualification.  E.g.:

audit.c:(.text+0x33361): undefined reference to `netlink_unicast'
(.text+0x333df): undefined reference to `netlink_unicast'
audit.c:(.text+0x3341d): undefined reference to `skb_queue_tail'
audit.c:(.text+0x33424): undefined reference to `kfree_skb'
audit.c:(.text+0x334cb): undefined reference to `kfree_skb'
audit.c:(.text+0x33597): undefined reference to `skb_put'
audit.c:(.text+0x3369b): undefined reference to `__alloc_skb'
audit.c:(.text+0x336d7): undefined reference to `kfree_skb'
(.text+0x3374c): undefined reference to `__alloc_skb'
auditfilter.c:(.text+0x35305): undefined reference to `skb_queue_tail'
lsm_audit.c:(.text+0x2873): undefined reference to `init_net'
lsm_audit.c:(.text+0x2878): undefined reference to `dev_get_by_index'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
Cc: John Johansen <john.johansen@canonical•com>
---
 security/apparmor/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100802.orig/security/apparmor/Kconfig
+++ linux-next-20100802/security/apparmor/Kconfig
@@ -1,6 +1,6 @@
 config SECURITY_APPARMOR
 	bool "AppArmor support"
-	depends on SECURITY
+	depends on SECURITY && NET
 	select AUDIT
 	select SECURITY_PATH
 	select SECURITYFS

  parent reply	other threads:[~2010-08-02 17:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02  4:44 linux-next: Tree for August 2 Stephen Rothwell
2010-08-02 17:27 ` linux-next: Tree for August 2 (scsi/pcmcia) Randy Dunlap
2010-08-02 20:10   ` Dominik Brodowski
2010-08-02 17:52 ` Randy Dunlap [this message]
2010-08-03  2:43   ` [PATCH -next] apparmor: depends on NET John Johansen
2010-08-05  3:15     ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100802105218.c2050fff.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle$(echo .)com \
    --cc=jmorris@namei$(echo .)org \
    --cc=john.johansen@canonical$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-security-module@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox