public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Dmitry Torokhov <dmitry.torokhov@gmail•com>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Alan Cox <alan@lxorguk•ukuu.org.uk>,
	Jason Wessel <jason.wessel@windriver•com>,
	Greg Kroah-Hartman <gregkh@suse•de>
Subject: linux-next: build failure after merge of the final tree (input tree related)
Date: Fri, 20 Aug 2010 13:12:24 +1000	[thread overview]
Message-ID: <20100820131224.02f7cb9f.sfr@canb.auug.org.au> (raw)

Hi Dmitry,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

In file included from drivers/gpu/drm/i915/i915_irq.c:29:
include/linux/sysrq.h:45: error: expected declaration specifiers or '...' before 'bool'

Caused by commit a821bafce37b26499e2bfbf2e6b96b0636efc014 ("Input: sysrq
- drop tty argument form handle_sysrq()") from the input tree which
(despite not mentioning this) changed an "int" argument to "bool" but
neglected to include linux/types.h.

I added this patch for today:

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Fri, 20 Aug 2010 13:06:30 +1000
Subject: [PATCH] input: using bool in sysrq.h requires including types.h

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 include/linux/sysrq.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/sysrq.h b/include/linux/sysrq.h
index 32d360a..387fa7d 100644
--- a/include/linux/sysrq.h
+++ b/include/linux/sysrq.h
@@ -15,6 +15,7 @@
 #define _LINUX_SYSRQ_H
 
 #include <linux/errno.h>
+#include <linux/types.h>
 
 /* Possible values of bitmask for enabling sysrq functions */
 /* 0x0001 is reserved for enable everything */
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

             reply	other threads:[~2010-08-20  3:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20  3:12 Stephen Rothwell [this message]
2010-08-21  7:39 ` linux-next: build failure after merge of the final tree (input tree related) Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2011-09-19  8:46 Stephen Rothwell
2011-09-19  9:01 ` Tobias Klauser
2010-12-29  1:51 Stephen Rothwell
2010-12-29  2:34 ` Dmitry Torokhov
2010-12-29 23:51   ` Stephen Rothwell
2010-12-30 18:06     ` Ping Cheng
2010-12-30 19:58       ` Geert Uytterhoeven
2010-12-30 20:10         ` Ping Cheng
2011-01-02  8:05     ` Dmitry Torokhov
2010-03-23  6:54 Stephen Rothwell
2010-03-23  7:31 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100820131224.02f7cb9f.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=alan@lxorguk$(echo .)ukuu.org.uk \
    --cc=dmitry.torokhov@gmail$(echo .)com \
    --cc=gregkh@suse$(echo .)de \
    --cc=jason.wessel@windriver$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox