From: Tobias Klauser <tklauser@distanz•ch>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail•com>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (input tree related)
Date: Mon, 19 Sep 2011 11:01:37 +0200 [thread overview]
Message-ID: <20110919090137.GM11405@distanz.ch> (raw)
In-Reply-To: <20110919184621.ac27f3d519e397a82efc6d4a@canb.auug.org.au>
On 2011-09-19 at 10:46:21 +0200, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
>
> drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata':
> drivers/input/keyboard/gpio_keys.c:500:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
> include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
> drivers/input/keyboard/gpio_keys.c:504:19: warning: assignment makes integer from pointer without a cast
> drivers/input/keyboard/gpio_keys.c:508:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
> include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
> drivers/input/keyboard/gpio_keys.c:509:20: warning: assignment makes integer from pointer without a cast
> drivers/input/keyboard/gpio_keys.c:515:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
> include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
> drivers/input/keyboard/gpio_keys.c:516:33: warning: assignment makes integer from pointer without a cast
> drivers/input/keyboard/gpio_keys.c:502:4: error: label 'out_fail' used but not defined
> drivers/input/keyboard/gpio_keys.c: At top level:
> drivers/input/keyboard/gpio_keys.c:523:7: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
> drivers/input/keyboard/gpio_keys.c:525:2: error: expected identifier or '(' before 'return'
> drivers/input/keyboard/gpio_keys.c:527:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token
> drivers/input/keyboard/gpio_keys.c:529:2: error: expected identifier or '(' before 'return'
> drivers/input/keyboard/gpio_keys.c:530:1: error: expected identifier or '(' before '}' token
> drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata':
> drivers/input/keyboard/gpio_keys.c:521:2: warning: control reaches end of non-void function
>
> Caused by commit d6ba97c9806b ("Input: gpio_keys - use
> of_property_read_u32()"). Mostly by a brace mismatch.
Sorry, my fault. I thought I compile-tested this but obviously didn't.
I'll send an updated patch to Dmitry.
Tobias
next prev parent reply other threads:[~2011-09-19 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 8:46 linux-next: build failure after merge of the final tree (input tree related) Stephen Rothwell
2011-09-19 9:01 ` Tobias Klauser [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-29 1:51 Stephen Rothwell
2010-12-29 2:34 ` Dmitry Torokhov
2010-12-29 23:51 ` Stephen Rothwell
2010-12-30 18:06 ` Ping Cheng
2010-12-30 19:58 ` Geert Uytterhoeven
2010-12-30 20:10 ` Ping Cheng
2011-01-02 8:05 ` Dmitry Torokhov
2010-08-20 3:12 Stephen Rothwell
2010-08-21 7:39 ` Dmitry Torokhov
2010-03-23 6:54 Stephen Rothwell
2010-03-23 7:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919090137.GM11405@distanz.ch \
--to=tklauser@distanz$(echo .)ch \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox