From: Randy Dunlap <randy.dunlap@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
gregkh@suse•de, driverdevel <devel@driverdev•osuosl.org>
Cc: akpm <akpm@linux-foundation•org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: [PATCH -next] staging: fix iio/gyro typos, build errors
Date: Sat, 13 Nov 2010 08:44:35 -0800 [thread overview]
Message-ID: <20101113084435.3850deb6.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20101112130547.c2a3c2c1.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle•com>
Typo causes build errors. Did anyone even build this driver?
Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
---
drivers/staging/iio/gyro/adis16251.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
Also has section mismatch warnings:
WARNING: drivers/staging/built-in.o(.data+0xe9b8): Section mismatch in reference from the variable spi_adis16255_drv to the function .devinit.text:spi_adis16255_probe()
The variable spi_adis16255_drv references
the function __devinit spi_adis16255_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
WARNING: drivers/staging/built-in.o(.data+0xe9c0): Section mismatch in reference from the variable spi_adis16255_drv to the function .devexit.text:spi_adis16255_remove()
The variable spi_adis16255_drv references
the function __devexit spi_adis16255_remove()
If the reference is valid then annotate the
variable with __exit* (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
--- linux-next-20101112.orig/drivers/staging/iio/gyro/adis16251.h
+++ linux-next-20101112/drivers/staging/iio/gyro/adis16251.h
@@ -56,14 +56,14 @@
#define ADIS16251_DIAG_STAT_POWER_HIGH (1<<1)
#define ADIS16251_DIAG_STAT_POWER_LOW (1<<0)
-#define ADIS16251_DIAG_STAT_ERR_MASK (ADIS16261_DIAG_STAT_ALARM2 | \
- ADIS16261_DIAG_STAT_ALARM1 | \
- ADIS16261_DIAG_STAT_SELF_TEST | \
- ADIS16261_DIAG_STAT_OVERFLOW | \
- ADIS16261_DIAG_STAT_SPI_FAIL | \
- ADIS16261_DIAG_STAT_FLASH_UPT | \
- ADIS16261_DIAG_STAT_POWER_HIGH | \
- ADIS16261_DIAG_STAT_POWER_LOW)
+#define ADIS16251_DIAG_STAT_ERR_MASK (ADIS16251_DIAG_STAT_ALARM2 | \
+ ADIS16251_DIAG_STAT_ALARM1 | \
+ ADIS16251_DIAG_STAT_SELF_TEST | \
+ ADIS16251_DIAG_STAT_OVERFLOW | \
+ ADIS16251_DIAG_STAT_SPI_FAIL | \
+ ADIS16251_DIAG_STAT_FLASH_UPT | \
+ ADIS16251_DIAG_STAT_POWER_HIGH | \
+ ADIS16251_DIAG_STAT_POWER_LOW)
/* GLOB_CMD */
#define ADIS16251_GLOB_CMD_SW_RESET (1<<7)
next prev parent reply other threads:[~2010-11-13 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 2:05 linux-next: Tree for November 12 Stephen Rothwell
2010-11-13 16:44 ` [PATCH -next] edac: use BIT_64() to eliminate warnings Randy Dunlap
2010-11-14 17:54 ` Borislav Petkov
[not found] ` <20101112130547.c2a3c2c1.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-11-13 16:44 ` [PATCH -next] iwlwifi: fix modular legacy build errors Randy Dunlap
2010-11-13 16:44 ` [PATCH -next] pci-sysfs: fix printk warnings Randy Dunlap
2010-11-13 16:44 ` Randy Dunlap [this message]
2010-11-13 16:44 ` [PATCH -next] x86/mrst: force support code to be built Randy Dunlap
2010-11-15 13:43 ` Alan Cox
2010-11-13 16:44 ` [PATCH -next] xen: fix header export to userspace Randy Dunlap
2010-11-15 10:23 ` Tony Finch
2010-11-15 18:15 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101113084435.3850deb6.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox