public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk•ukuu.org.uk>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	akpm <akpm@linux-foundation•org>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	x86@kernel•org
Subject: Re: [PATCH -next] x86/mrst: force support code to be built
Date: Mon, 15 Nov 2010 13:43:25 +0000	[thread overview]
Message-ID: <20101115134325.199ab1f3@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20101113084437.a9707260.randy.dunlap@oracle.com>

On Sat, 13 Nov 2010 08:44:37 -0800
Randy Dunlap <randy.dunlap@oracle•com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle•com>
> 
> Fix mrst.c build: make sure that its called functions are built.
> 
> arch/x86/built-in.o: In function `mrst_reboot':
> mrst.c:(.text+0x2250b): undefined reference to `intel_scu_ipc_simple_command'
> arch/x86/built-in.o: In function `mrst_power_off':
> mrst.c:(.text+0x2252e): undefined reference to `intel_scu_ipc_simple_command'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> ---
>  arch/x86/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20101112.orig/arch/x86/Kconfig
> +++ linux-next-20101112/arch/x86/Kconfig
> @@ -387,6 +387,7 @@ config X86_MRST
>  	select APB_TIMER
>  	select I2C
>  	select SPI
> +	select X86_PLATFORM_DEVICES

We need the SCU so in fact we really want to select that. I'll send a
patch to Ingo.

  reply	other threads:[~2010-11-15 13:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12  2:05 linux-next: Tree for November 12 Stephen Rothwell
2010-11-13 16:44 ` [PATCH -next] edac: use BIT_64() to eliminate warnings Randy Dunlap
2010-11-14 17:54   ` Borislav Petkov
     [not found] ` <20101112130547.c2a3c2c1.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-11-13 16:44   ` [PATCH -next] iwlwifi: fix modular legacy build errors Randy Dunlap
2010-11-13 16:44 ` [PATCH -next] pci-sysfs: fix printk warnings Randy Dunlap
2010-11-13 16:44 ` [PATCH -next] staging: fix iio/gyro typos, build errors Randy Dunlap
2010-11-13 16:44 ` [PATCH -next] x86/mrst: force support code to be built Randy Dunlap
2010-11-15 13:43   ` Alan Cox [this message]
2010-11-13 16:44 ` [PATCH -next] xen: fix header export to userspace Randy Dunlap
2010-11-15 10:23   ` Tony Finch
2010-11-15 18:15   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101115134325.199ab1f3@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk$(echo .)ukuu.org.uk \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=randy.dunlap@oracle$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=x86@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox