From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Zimny Lech <napohybelskurwysynom2010@gmail•com>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Arnd Bergmann <arnd@arndb•de>,
Linus <torvalds@linux-foundation•org>
Subject: Re: linux-next: Tree for November 17
Date: Thu, 18 Nov 2010 10:14:59 +1100 [thread overview]
Message-ID: <20101118101459.472d540b.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20101117095920.2b9e2e6a.randy.dunlap@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On Wed, 17 Nov 2010 09:59:20 -0800 Randy Dunlap <randy.dunlap@oracle•com> wrote:
>
> Why was #include <linux/smp_lock.h> removed from <linux/hardirq.h> ?
>
> I added #include <linux/smp_lock.h> to i387.h, but them mm/filemap.c build fails
> with the same error:
>
> linux-next-20101117/mm/filemap.c: In function 'iov_iter_copy_from_user_atomic':
> linux-next-20101117/mm/filemap.c:1936: error: implicit declaration of function 'kernel_locked'
Was this fixed before Linus took that patch? Also, the #include of
linux/smp_lock.h in linux/hardirq.h was the only line between #ifdef
CONFIG_PREEMPT and #endif ... was this patch even reviewed?
Maybe (after it was reviewed) it should have been given more time in
linux-next before being merged.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2010-11-17 23:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 3:09 linux-next: Tree for November 17 Stephen Rothwell
2010-11-17 17:23 ` Zimny Lech
2010-11-17 17:59 ` Randy Dunlap
2010-11-17 23:14 ` Stephen Rothwell [this message]
2010-11-17 23:24 ` Randy Dunlap
2010-11-18 0:16 ` Stephen Rothwell
2010-11-17 22:53 ` Zimny Lech
2010-11-17 23:09 ` Randy Dunlap
2010-11-17 23:38 ` [PATCH -next] staging: clearpad_tm1217 depends on INPUT Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2009-11-17 8:53 linux-next: Tree for November 17 Stephen Rothwell
2008-11-17 7:06 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118101459.472d540b.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=arnd@arndb$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=napohybelskurwysynom2010@gmail$(echo .)com \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox