From: Randy Dunlap <rdunlap@xenotime•net>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Liam Girdwood <lrg@slimlogic•co.uk>,
Mark Brown <broonie@opensource•wolfsonmicro.com>
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Tree for November 25 (snd/soc/codecs)
Date: Thu, 25 Nov 2010 18:45:13 -0800 [thread overview]
Message-ID: <20101125184513.fdb20279.rdunlap@xenotime.net> (raw)
In-Reply-To: <20101125164929.3a719716.sfr@canb.auug.org.au>
On Thu, 25 Nov 2010 16:49:29 +1100 Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20101124:
When CONFIG_I2C is not enabled:
sound/soc/codecs/wm8737.c:521:error: 'i2c_master_send' undeclared (first use in this function)
but CONFIG_SND_SOC_I2C_AND_SPI=m
and CONFIG_SND_SOC_WM8737=m
Should SND_SOC_I2C_AND_SPI depend on I2C && SPI ??
config SND_SOC_I2C_AND_SPI
tristate
default m if I2C=m
default y if I2C=y
default y if SPI_MASTER=y
This doesn't handle the I2C disabled case, hence the build error.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-11-26 2:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 5:49 linux-next: Tree for November 25 Stephen Rothwell
2010-11-25 13:25 ` Alan Cox
2010-11-25 22:31 ` Stephen Rothwell
2010-11-25 14:24 ` Zimny Lech
2010-11-26 2:45 ` Randy Dunlap [this message]
2010-11-26 11:21 ` linux-next: Tree for November 25 (snd/soc/codecs) Mark Brown
2010-11-26 16:27 ` Randy Dunlap
2010-11-26 16:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125184513.fdb20279.rdunlap@xenotime.net \
--to=rdunlap@xenotime$(echo .)net \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lrg@slimlogic$(echo .)co.uk \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox