From: Randy Dunlap <rdunlap@xenotime•net>
To: Mark Brown <broonie@opensource•wolfsonmicro.com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Liam Girdwood <lrg@slimlogic•co.uk>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Tree for November 25 (snd/soc/codecs)
Date: Fri, 26 Nov 2010 08:27:11 -0800 [thread overview]
Message-ID: <20101126082711.9c362c87.rdunlap@xenotime.net> (raw)
In-Reply-To: <20101126112145.GA30360@rakim.wolfsonmicro.main>
On Fri, 26 Nov 2010 11:21:46 +0000 Mark Brown wrote:
> On Thu, Nov 25, 2010 at 06:45:13PM -0800, Randy Dunlap wrote:
>
> > config SND_SOC_I2C_AND_SPI
> > tristate
> > default m if I2C=m
> > default y if I2C=y
> > default y if SPI_MASTER=y
>
> > This doesn't handle the I2C disabled case, hence the build error.
>
> It does, anything with this configuration should have appropriate ifdefs
> to cover it, it's just that one is missed here. The purpose of the
> symbol is to ensure we don't try to build one of these drivers into the
> kernel when I2C is modular.
so we can look forward to a patch for this build error?
sound/soc/codecs/wm8737.c:563:error: 'i2c_master_send' undeclared (first use in this function)
thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-11-26 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 5:49 linux-next: Tree for November 25 Stephen Rothwell
2010-11-25 13:25 ` Alan Cox
2010-11-25 22:31 ` Stephen Rothwell
2010-11-25 14:24 ` Zimny Lech
2010-11-26 2:45 ` linux-next: Tree for November 25 (snd/soc/codecs) Randy Dunlap
2010-11-26 11:21 ` Mark Brown
2010-11-26 16:27 ` Randy Dunlap [this message]
2010-11-26 16:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126082711.9c362c87.rdunlap@xenotime.net \
--to=rdunlap@xenotime$(echo .)net \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lrg@slimlogic$(echo .)co.uk \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox