* [PATCH -next] arm: trivial: add missing argument to printk
@ 2010-12-03 19:06 Anand Gadiyar
2010-12-03 19:14 ` Russell King - ARM Linux
0 siblings, 1 reply; 2+ messages in thread
From: Anand Gadiyar @ 2010-12-03 19:06 UTC (permalink / raw)
To: linux-arm-kernel, linux-next; +Cc: Anand Gadiyar, Russell King
Patch "ARM: CPU hotplug: move cpu_killed completion to core code"
accidentally left out an argument to a printk call. This introduces
the following build warning - fix this.
arch/arm/kernel/smp.c: In function '__cpu_die':
arch/arm/kernel/smp.c:216: warning: too few arguments for format
Signed-off-by: Anand Gadiyar <gadiyar@ti•com>
Cc: Russell King <rmk+kernel@arm•linux.org.uk>
---
arch/arm/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: mainline/arch/arm/kernel/smp.c
===================================================================
--- mainline.orig/arch/arm/kernel/smp.c
+++ mainline/arch/arm/kernel/smp.c
@@ -213,7 +213,7 @@ static DECLARE_COMPLETION(cpu_died);
void __cpu_die(unsigned int cpu)
{
if (wait_for_completion_timeout(&cpu_died, 5000)) {
- printk(KERN_ERR "CPU%u: cpu didn't die\n");
+ printk(KERN_ERR "CPU%u: cpu didn't die\n", cpu);
return;
}
printk(KERN_NOTICE "CPU%u: shutdown\n", cpu);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] arm: trivial: add missing argument to printk
2010-12-03 19:06 [PATCH -next] arm: trivial: add missing argument to printk Anand Gadiyar
@ 2010-12-03 19:14 ` Russell King - ARM Linux
0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2010-12-03 19:14 UTC (permalink / raw)
To: Anand Gadiyar; +Cc: linux-arm-kernel, linux-next
On Sat, Dec 04, 2010 at 12:36:12AM +0530, Anand Gadiyar wrote:
> Patch "ARM: CPU hotplug: move cpu_killed completion to core code"
> accidentally left out an argument to a printk call. This introduces
> the following build warning - fix this.
Already caught this.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-03 19:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-03 19:06 [PATCH -next] arm: trivial: add missing argument to printk Anand Gadiyar
2010-12-03 19:14 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox