* [PATCH] configfs: change depends -> select SYSFS
@ 2011-01-10 19:45 Nicholas A. Bellinger
2011-01-10 23:46 ` Joel Becker
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas A. Bellinger @ 2011-01-10 19:45 UTC (permalink / raw)
To: Joel Becker
Cc: linux-scsi, linux-next, linux-fsdevel, Randy Dunlap,
James Bottomley, Stephen Rothwell, Nicholas Bellinger
From: Nicholas Bellinger <nab@linux-iscsi•org>
Hi Joel,
This is a fix for linux-next that Randy reported over the holidays but has not
made it in just yet. Please have a look and give your signoff at your earliest
convience.
Thanks!
----------------------------------------------------------------------------------
This patch changes configfs to select SYSFS to fix the following:
warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
This patch also fixes whitespace breakage in the 'help' section.
Reported-by: Randy Dunlap <randy.dunlap@oracle•com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi•org>
---
fs/configfs/Kconfig | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/configfs/Kconfig b/fs/configfs/Kconfig
index 13587cc..0e4bd23 100644
--- a/fs/configfs/Kconfig
+++ b/fs/configfs/Kconfig
@@ -1,11 +1,11 @@
config CONFIGFS_FS
tristate "Userspace-driven configuration filesystem"
- depends on SYSFS
+ select SYSFS
help
- configfs is a ram-based filesystem that provides the converse
- of sysfs's functionality. Where sysfs is a filesystem-based
- view of kernel objects, configfs is a filesystem-based manager
- of kernel objects, or config_items.
+ configfs is a RAM-based filesystem that provides the converse
+ of sysfs's functionality. Where sysfs is a filesystem-based
+ view of kernel objects, configfs is a filesystem-based manager
+ of kernel objects, or config_items.
- Both sysfs and configfs can and should exist together on the
- same system. One is not a replacement for the other.
+ Both sysfs and configfs can and should exist together on the
+ same system. One is not a replacement for the other.
--
1.7.3.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configfs: change depends -> select SYSFS
2011-01-10 19:45 [PATCH] configfs: change depends -> select SYSFS Nicholas A. Bellinger
@ 2011-01-10 23:46 ` Joel Becker
0 siblings, 0 replies; 2+ messages in thread
From: Joel Becker @ 2011-01-10 23:46 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: Joel Becker, linux-scsi, linux-next, linux-fsdevel, Randy Dunlap,
James Bottomley, Stephen Rothwell
On Mon, Jan 10, 2011 at 11:45:08AM -0800, Nicholas A. Bellinger wrote:
> This patch changes configfs to select SYSFS to fix the following:
>
> warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
If others are selecting CONFIGFS_FS, I'm thinking that this must
go in. So
Acked-by: Joel Becker <jlbec@evilplan•org>
>
> This patch also fixes whitespace breakage in the 'help' section.
>
> Reported-by: Randy Dunlap <randy.dunlap@oracle•com>
> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi•org>
> ---
> fs/configfs/Kconfig | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/fs/configfs/Kconfig b/fs/configfs/Kconfig
> index 13587cc..0e4bd23 100644
> --- a/fs/configfs/Kconfig
> +++ b/fs/configfs/Kconfig
> @@ -1,11 +1,11 @@
> config CONFIGFS_FS
> tristate "Userspace-driven configuration filesystem"
> - depends on SYSFS
> + select SYSFS
> help
> - configfs is a ram-based filesystem that provides the converse
> - of sysfs's functionality. Where sysfs is a filesystem-based
> - view of kernel objects, configfs is a filesystem-based manager
> - of kernel objects, or config_items.
> + configfs is a RAM-based filesystem that provides the converse
> + of sysfs's functionality. Where sysfs is a filesystem-based
> + view of kernel objects, configfs is a filesystem-based manager
> + of kernel objects, or config_items.
>
> - Both sysfs and configfs can and should exist together on the
> - same system. One is not a replacement for the other.
> + Both sysfs and configfs can and should exist together on the
> + same system. One is not a replacement for the other.
> --
> 1.7.3.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Life's Little Instruction Book #451
"Don't be afraid to say, 'I'm sorry.'"
http://www.jlbec.org/
jlbec@evilplan•org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-10 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 19:45 [PATCH] configfs: change depends -> select SYSFS Nicholas A. Bellinger
2011-01-10 23:46 ` Joel Becker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox