From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Dmitry Torokhov <dmitry.torokhov@gmail•com>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Tejun Heo <tj@kernel•org>
Subject: Re: linux-next: build failure after merge of the workqueues tree
Date: Mon, 21 Feb 2011 13:27:08 +1100 [thread overview]
Message-ID: <20110221132708.e9ed5f8f.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20110218145747.f4b26b91.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]
Hi Dmitry,
On Fri, 18 Feb 2011 14:57:47 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the workqueues tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/input/input-polldev.c: In function 'input_polldev_init':
> drivers/input/input-polldev.c:259: error: 'WQ_FREEZEABLE' undeclared (first use in this function)
>
> Caused by commit 58a69cb47ec6991bf006a3e5d202e8571b0327a4 ("workqueue,
> freezer: unify spelling of 'freeze' + 'able' to 'freezable'") interacting
> with commit 8fb3f6f6bf6e17e97712d216f230ba05f2e88ed8 ("Input:
> input-polldev - create workqueue upfront") from the input tree.
>
> I applied the following fix up patch (and can carry it as necessary):
This patch is now applicable after the input tree merge as the workqueues
patch has been merged into Linus' tree. So, Dmitry, if you merge Linus'
tree sometime, you should apply this merge fixup.
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Fri, 18 Feb 2011 14:50:46 +1100
> Subject: [PATCH] input: update for FREEZEABLE -> FREEZABLE change
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> drivers/input/input-polldev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/input-polldev.c b/drivers/input/input-polldev.c
> index 0a5304c..d89e9a9 100644
> --- a/drivers/input/input-polldev.c
> +++ b/drivers/input/input-polldev.c
> @@ -257,7 +257,7 @@ static int __init input_polldev_init(void)
> * system goes into sleep mode.
> */
> polldev_wq = alloc_workqueue("ipolldev_wq",
> - WQ_FREEZEABLE | WQ_UNBOUND, 0);
> + WQ_FREEZABLE | WQ_UNBOUND, 0);
> if (!polldev_wq) {
> pr_err("failed to create ipolldev_wq workqueue\n");
> return -ENOMEM;
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-02-21 2:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 3:57 linux-next: build failure after merge of the workqueues tree Stephen Rothwell
2011-02-18 9:07 ` Tejun Heo
2011-02-21 2:27 ` Stephen Rothwell [this message]
2011-02-21 5:48 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2025-04-15 4:01 Stephen Rothwell
2025-04-15 13:24 ` Tamir Duberstein
2025-04-15 14:59 ` Tejun Heo
2025-04-17 4:26 ` Stephen Rothwell
2025-04-17 6:15 ` Tejun Heo
2025-04-17 6:35 ` Stephen Rothwell
2017-11-02 3:34 Stephen Rothwell
2017-11-03 13:59 ` Tejun Heo
2015-06-20 10:26 Stephen Rothwell
2011-02-17 3:33 Stephen Rothwell
2011-02-17 9:23 ` Tejun Heo
2011-02-09 4:12 Stephen Rothwell
2011-02-09 8:37 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221132708.e9ed5f8f.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox