From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Tejun Heo <tj@kernel•org>
Cc: Tamir Duberstein <tamird@gmail•com>,
Benno Lossin <benno.lossin@proton•me>,
Alice Ryhl <aliceryhl@google•com>,
Andreas Hindborg <a.hindborg@kernel•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the workqueues tree
Date: Thu, 17 Apr 2025 14:26:36 +1000 [thread overview]
Message-ID: <20250417142636.0e73728a@canb.auug.org.au> (raw)
In-Reply-To: <Z_50QbWczACrwL5f@slm.duckdns.org>
[-- Attachment #1: Type: text/plain, Size: 2086 bytes --]
Hi Tejun,
On Tue, 15 Apr 2025 04:59:13 -1000 Tejun Heo <tj@kernel•org> wrote:
>
> On Tue, Apr 15, 2025 at 09:24:32AM -0400, Tamir Duberstein wrote:
> > On Tue, Apr 15, 2025 at 12:01 AM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > >
> > > After merging the workqueues tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > error[E0308]: mismatched types
> > > --> rust/kernel/lib.rs:204:9
> > > |
> > > 204 | ptr.sub(offset) as *const $type
> > > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ types differ in mutability
> > > |
> > > ::: rust/kernel/workqueue.rs:495:18
> > > |
> > > 495 | ) -> *mut Self {
> > > | --------- expected `*mut ClosureWork<T>` because of return type
> > > ...
> > > 505 | / impl_has_work! {
> > > 506 | | impl{T} HasWork<Self> for ClosureWork<T> { self.work }
> > > 507 | | }
> > > | |_- in this macro invocation
> > > |
> > > = note: expected raw pointer `*mut ClosureWork<T>`
> > > found raw pointer `*const ClosureWork<T>`
> > > = note: this error originates in the macro `$crate::container_of` which comes from the expansion of the macro `impl_has_work` (in Nightly builds, run with -Z macro-backtrace for more info)
> > >
> > > error: aborting due to 1 previous error
> > >
> > > For more information about this error, try `rustc --explain E0308`.
> > >
> > > Caused by commit
> > >
> > > 345e029b561e ("rust: workqueue: remove HasWork::OFFSET")
> > >
> > > I have used the workqueues tree from next-20250414 for today.
> >
> > HI Stephen, I believe Tejun plans to back this out. See
> > https://lore.kernel.org/all/CAJ-ks9k2FEfL4SWw3ThhhozAeHB=Ue9-_1pxb9XVPRR2E1Z+SQ@mail.gmail.com/.
>
> Yeah, sorry about that. It was in the tree only for a couple hours and then
> got rewound, but we got a bit unfortunate with linux-next pulling. Should be
> okay today.
I am still seeing this failure. Forgot to push out?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-04-17 4:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 4:01 linux-next: build failure after merge of the workqueues tree Stephen Rothwell
2025-04-15 13:24 ` Tamir Duberstein
2025-04-15 14:59 ` Tejun Heo
2025-04-17 4:26 ` Stephen Rothwell [this message]
2025-04-17 6:15 ` Tejun Heo
2025-04-17 6:35 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2017-11-02 3:34 Stephen Rothwell
2017-11-03 13:59 ` Tejun Heo
2015-06-20 10:26 Stephen Rothwell
2011-02-18 3:57 Stephen Rothwell
2011-02-18 9:07 ` Tejun Heo
2011-02-21 2:27 ` Stephen Rothwell
2011-02-21 5:48 ` Dmitry Torokhov
2011-02-17 3:33 Stephen Rothwell
2011-02-17 9:23 ` Tejun Heo
2011-02-09 4:12 Stephen Rothwell
2011-02-09 8:37 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417142636.0e73728a@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=a.hindborg@kernel$(echo .)org \
--cc=aliceryhl@google$(echo .)com \
--cc=benno.lossin@proton$(echo .)me \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=tamird@gmail$(echo .)com \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox