public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Tejun Heo <tj@kernel•org>,
	linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Matt Fleming <matt.fleming@intel•com>
Subject: Re: linux-next: build warning after merge of the ptrace tree
Date: Mon, 29 Aug 2011 20:20:18 +0200	[thread overview]
Message-ID: <20110829182018.GA14729@redhat.com> (raw)
In-Reply-To: <20110829152704.e533760bfb83fc7480333b20@canb.auug.org.au>

Hi Stephen,

On 08/29, Stephen Rothwell wrote:
>
> After merging the ptrace tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/autofs4/waitq.c: In function 'autofs4_wait':
> fs/autofs4/waitq.c:462:17: warning: unused variable 'irqflags'
>
> Introduced by commit 33ee1d9bc213 ("autofs4: Use set_current_blocked()").

Argh. Thanks again.

I've committed the trivial fix.

Oleg.

commit 2efd0a8f5a5e981022faaec780ee00c05eeee8aa
Author: Oleg Nesterov <oleg@redhat•com>
Date:   Mon Aug 29 20:17:24 2011 +0200

    autofs4_wait: remove the unused irqflags variable
    
    irqflags is not used since 33ee1d9bc213, remove it.
    
    Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
    Signed-off-by: Oleg Nesterov <oleg@redhat•com>

diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 58ba49a..09fb503 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -459,7 +459,6 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry,
 	if (wq->name.name) {
 		/* Block all but "shutdown" signals while waiting */
 		sigset_t oldset, blocked;
-		unsigned long irqflags;
 
 		oldset = current->blocked;
 		siginitsetinv(&blocked, SHUTDOWN_SIGS & ~oldset.sig[0]);

  reply	other threads:[~2011-08-29 18:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29  5:27 linux-next: build warning after merge of the ptrace tree Stephen Rothwell
2011-08-29 18:20 ` Oleg Nesterov [this message]
2011-08-29 20:18   ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829182018.GA14729@redhat.com \
    --to=oleg@redhat$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=matt.fleming@intel$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=tj@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox