* linux-next: build warning after merge of the ptrace tree
@ 2011-08-29 5:27 Stephen Rothwell
2011-08-29 18:20 ` Oleg Nesterov
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2011-08-29 5:27 UTC (permalink / raw)
To: Tejun Heo, Oleg Nesterov; +Cc: linux-next, linux-kernel, Matt Fleming
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
Hi all,
After merging the ptrace tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/autofs4/waitq.c: In function 'autofs4_wait':
fs/autofs4/waitq.c:462:17: warning: unused variable 'irqflags'
Introduced by commit 33ee1d9bc213 ("autofs4: Use set_current_blocked()").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: build warning after merge of the ptrace tree
2011-08-29 5:27 linux-next: build warning after merge of the ptrace tree Stephen Rothwell
@ 2011-08-29 18:20 ` Oleg Nesterov
2011-08-29 20:18 ` Matt Fleming
0 siblings, 1 reply; 3+ messages in thread
From: Oleg Nesterov @ 2011-08-29 18:20 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Tejun Heo, linux-next, linux-kernel, Matt Fleming
Hi Stephen,
On 08/29, Stephen Rothwell wrote:
>
> After merging the ptrace tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/autofs4/waitq.c: In function 'autofs4_wait':
> fs/autofs4/waitq.c:462:17: warning: unused variable 'irqflags'
>
> Introduced by commit 33ee1d9bc213 ("autofs4: Use set_current_blocked()").
Argh. Thanks again.
I've committed the trivial fix.
Oleg.
commit 2efd0a8f5a5e981022faaec780ee00c05eeee8aa
Author: Oleg Nesterov <oleg@redhat•com>
Date: Mon Aug 29 20:17:24 2011 +0200
autofs4_wait: remove the unused irqflags variable
irqflags is not used since 33ee1d9bc213, remove it.
Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Oleg Nesterov <oleg@redhat•com>
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 58ba49a..09fb503 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -459,7 +459,6 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry,
if (wq->name.name) {
/* Block all but "shutdown" signals while waiting */
sigset_t oldset, blocked;
- unsigned long irqflags;
oldset = current->blocked;
siginitsetinv(&blocked, SHUTDOWN_SIGS & ~oldset.sig[0]);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: linux-next: build warning after merge of the ptrace tree
2011-08-29 18:20 ` Oleg Nesterov
@ 2011-08-29 20:18 ` Matt Fleming
0 siblings, 0 replies; 3+ messages in thread
From: Matt Fleming @ 2011-08-29 20:18 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Stephen Rothwell, Tejun Heo, linux-next, linux-kernel
On Mon, 2011-08-29 at 20:20 +0200, Oleg Nesterov wrote:
> Hi Stephen,
>
> On 08/29, Stephen Rothwell wrote:
> >
> > After merging the ptrace tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > fs/autofs4/waitq.c: In function 'autofs4_wait':
> > fs/autofs4/waitq.c:462:17: warning: unused variable 'irqflags'
> >
> > Introduced by commit 33ee1d9bc213 ("autofs4: Use set_current_blocked()").
>
> Argh. Thanks again.
>
> I've committed the trivial fix.
Thanks Oleg! Sorry about that, my build was pretty loud and I missed
this warning in the noise.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-29 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-29 5:27 linux-next: build warning after merge of the ptrace tree Stephen Rothwell
2011-08-29 18:20 ` Oleg Nesterov
2011-08-29 20:18 ` Matt Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox