* [PATCH -next] qnx4fs: Use kmemdup rather than duplicating its implementation
@ 2011-11-13 17:47 Anders Larsen
0 siblings, 0 replies; only message in thread
From: Anders Larsen @ 2011-11-13 17:47 UTC (permalink / raw)
To: linux-next, linux-kernel; +Cc: Thomas Meyer
From: Thomas Meyer <thomas@m3y3r•de>
Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r•de>
Signed-off-by: Anders Larsen <al@alarsen•net>
---
diff -u -p a/fs/qnx4/inode.c b/fs/qnx4/inode.c
--- a/fs/qnx4/inode.c 2011-11-07 19:38:23.987165894 +0100
+++ b/fs/qnx4/inode.c 2011-11-08 10:33:59.882543999 +0100
@@ -199,12 +199,13 @@ static const char *qnx4_checkroot(struct
if (!strcmp(rootdir->di_fname,
QNX4_BMNAME)) {
found = 1;
- qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL );
+ qnx4_sb(sb)->BitMap = kmemdup(rootdir,
+ sizeof(struct qnx4_inode_entry),
+ GFP_KERNEL);
if (!qnx4_sb(sb)->BitMap) {
brelse (bh);
return "not enough memory for bitmap inode";
- }
- memcpy( qnx4_sb(sb)->BitMap, rootdir, sizeof( struct qnx4_inode_entry ) ); /* keep bitmap inode known */
+ }/* keep bitmap inode known */
break;
}
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-11-13 18:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-13 17:47 [PATCH -next] qnx4fs: Use kmemdup rather than duplicating its implementation Anders Larsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox