* Breakage from ARM when building x86
@ 2012-02-14 16:44 Alan Cox
2012-02-14 16:53 ` Russell King
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2012-02-14 16:44 UTC (permalink / raw)
To: linux-next, rmk
Either this needs the headers fixing or should be protected by an ARM
config, not sure which
drivers/mfd/twl-core.c: In function ‘twl_probe’:
drivers/mfd/twl-core.c:1218:2: error: implicit declaration of function
‘irq_alloc_descs’ [-Werror=implicit-function-declaration]
drivers/mfd/twl-core.c:1226:2: error: implicit declaration of function
‘irq_domain_add_legacy’ [-Werror=implicit-function-declaration]
drivers/mfd/twl-core.c:1227:11: error: ‘irq_domain_simple_ops’ undeclared
(first use in this function) drivers/mfd/twl-core.c:1227:11: note: each
undeclared identifier is reported only once for each function it appears
in cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/twl-core.o] Error 1
make[1]: *** [drivers/mfd] Error 2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Breakage from ARM when building x86
2012-02-14 16:44 Breakage from ARM when building x86 Alan Cox
@ 2012-02-14 16:53 ` Russell King
2012-02-14 17:09 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2012-02-14 16:53 UTC (permalink / raw)
To: Alan Cox, Grant Likely; +Cc: linux-next
On Tue, Feb 14, 2012 at 04:44:53PM +0000, Alan Cox wrote:
> Either this needs the headers fixing or should be protected by an ARM
> config, not sure which
At a guess, this is from linux-next ?
> drivers/mfd/twl-core.c: In function ‘twl_probe’:
> drivers/mfd/twl-core.c:1218:2: error: implicit declaration of function
> ‘irq_alloc_descs’ [-Werror=implicit-function-declaration]
> drivers/mfd/twl-core.c:1226:2: error: implicit declaration of function
> ‘irq_domain_add_legacy’ [-Werror=implicit-function-declaration]
> drivers/mfd/twl-core.c:1227:11: error: ‘irq_domain_simple_ops’ undeclared
> (first use in this function) drivers/mfd/twl-core.c:1227:11: note: each
> undeclared identifier is reported only once for each function it appears
> in cc1: some warnings being treated as errors
This has nothing to do with me ;) You're not the first to report it today.
I'm told by OMAP people that TWL gets used on x86 as well so it can't be
restricted to just ARM.
This is probably due to the irq domain stuff coming out of Grant's tree.
So no, really not anything to do with ARM.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Breakage from ARM when building x86
2012-02-14 16:53 ` Russell King
@ 2012-02-14 17:09 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-02-14 17:09 UTC (permalink / raw)
To: Russell King; +Cc: Alan Cox, linux-next
On Tue, Feb 14, 2012 at 9:53 AM, Russell King <rmk@arm•linux.org.uk> wrote:
> On Tue, Feb 14, 2012 at 04:44:53PM +0000, Alan Cox wrote:
>> Either this needs the headers fixing or should be protected by an ARM
>> config, not sure which
>
> At a guess, this is from linux-next ?
>
>> drivers/mfd/twl-core.c: In function ‘twl_probe’:
>> drivers/mfd/twl-core.c:1218:2: error: implicit declaration of function
>> ‘irq_alloc_descs’ [-Werror=implicit-function-declaration]
>> drivers/mfd/twl-core.c:1226:2: error: implicit declaration of function
>> ‘irq_domain_add_legacy’ [-Werror=implicit-function-declaration]
>> drivers/mfd/twl-core.c:1227:11: error: ‘irq_domain_simple_ops’ undeclared
>> (first use in this function) drivers/mfd/twl-core.c:1227:11: note: each
>> undeclared identifier is reported only once for each function it appears
>> in cc1: some warnings being treated as errors
>
> This has nothing to do with me ;) You're not the first to report it today.
> I'm told by OMAP people that TWL gets used on x86 as well so it can't be
> restricted to just ARM.
>
> This is probably due to the irq domain stuff coming out of Grant's tree.
>
> So no, really not anything to do with ARM.
This is irq_domain related. It's related to an API change. I'm
tracking to get it solved, either by moving the twl commit into the
irqdomain branch or by deferring the api change to v3.5.
I've also got a patch that converts x86 over to the new api, but I
don't have sufficient review to put it into the irqdomain tree yet.
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-14 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-14 16:44 Breakage from ARM when building x86 Alan Cox
2012-02-14 16:53 ` Russell King
2012-02-14 17:09 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox