From: Jason <jason@lakedaemon•net>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: michael@walle•cc, linux-crypto@vger•kernel.org,
linux-next@vger•kernel.org
Subject: Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)
Date: Sun, 11 Mar 2012 22:32:44 -0400 [thread overview]
Message-ID: <20120312023244.GV5050@titan.lakedaemon.net> (raw)
In-Reply-To: <CAP=VYLpm9B7i9MSGTc4ogVPACmC3J1SVtNDugoYop5mJ8gLb9g@mail.gmail.com>
On Sun, Mar 11, 2012 at 12:17:29PM -0400, Paul Gortmaker wrote:
> On Sat, Mar 10, 2012 at 8:42 PM, Jason Cooper <jason@lakedaemon•net> wrote:
> > On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote:
> >> Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next)
> >>
> >> "ARM: kirkwood: mv_cesa devicetree bindings"
> >>
> >> fails to compile as follows:
> >>
> >> CC drivers/crypto/mv_cesa.o
> >> drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr'
> >> drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function)
> >> drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant
> >> drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table')
> >>
> >> because it is missing the linux/of.h header file.
> >>
> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
> >
> > Paul,
> >
> > Thanks for the patch. Unfortunately, I'm not learning fast enough. ;-)
> > This series has been in a lot of flux lately, as you've experienced.
> >
> > The good news is, after talking with Olaf and Arnd, I think I have a
> > good workflow figured out. Hopefully, failures like this won't happen
> > in the future.
>
> Sounds good -- don't be too hard on yourself wrt. a minor breakage.
> Feel free to just squish the above patch into whatever updates you
> have going. I don't see it needing to exist as a standalone commit.
Thanks, it's definitely better that it be squashed into the existing
commit. I wouldn't want a bisect to land in between it down the road.
thx,
Jason.
prev parent reply other threads:[~2012-03-12 2:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 19:58 [PATCH] crypto: fix build failure in mv_cesa.c (missing of header) Paul Gortmaker
2012-03-11 1:42 ` Jason Cooper
2012-03-11 16:17 ` Paul Gortmaker
2012-03-12 2:32 ` Jason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312023244.GV5050@titan.lakedaemon.net \
--to=jason@lakedaemon$(echo .)net \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=michael@walle$(echo .)cc \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox