public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jason Cooper <jason@lakedaemon•net>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: michael@walle•cc, linux-crypto@vger•kernel.org,
	linux-next@vger•kernel.org
Subject: Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)
Date: Sat, 10 Mar 2012 20:42:26 -0500	[thread overview]
Message-ID: <20120311014226.GU5050@titan.lakedaemon.net> (raw)
In-Reply-To: <1331323105-21034-1-git-send-email-paul.gortmaker@windriver.com>

On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote:
> Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next)
> 
>     "ARM: kirkwood: mv_cesa devicetree bindings"
> 
> fails to compile as follows:
> 
>  CC      drivers/crypto/mv_cesa.o
>  drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr'
>  drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function)
>  drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant
>  drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table')
> 
> because it is missing the linux/of.h header file.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>

Paul,

Thanks for the patch.  Unfortunately, I'm not learning fast enough.  ;-)
This series has been in a lot of flux lately, as you've experienced.

The good news is, after talking with Olaf and Arnd, I think I have a
good workflow figured out.  Hopefully, failures like this won't happen
in the future.

As an fyi, I'm probably going to take kirkwood_dt_staging down (or, label
it broken ;-) )  I intended it as a publicly viewable branch of "what's
coming down the pipe", but it's not working out the way I intended.

As for mv_cesa, it's next on my list.  As soon as I figure out the irq
stuff.

Thanks for testing.

Jason.

> 
> diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
> index b7a3d48..093e214 100644
> --- a/drivers/crypto/mv_cesa.c
> +++ b/drivers/crypto/mv_cesa.c
> @@ -10,6 +10,7 @@
>  #include <crypto/algapi.h>
>  #include <linux/crypto.h>
>  #include <linux/interrupt.h>
> +#include <linux/of.h>
>  #include <linux/io.h>
>  #include <linux/kthread.h>
>  #include <linux/platform_device.h>
> -- 
> 1.7.9.1
> 

next prev parent reply	other threads:[~2012-03-11  1:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-09 19:58 [PATCH] crypto: fix build failure in mv_cesa.c (missing of header) Paul Gortmaker
2012-03-11  1:42 ` Jason Cooper [this message]
2012-03-11 16:17   ` Paul Gortmaker
2012-03-12  2:32     ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120311014226.GU5050@titan.lakedaemon.net \
    --to=jason@lakedaemon$(echo .)net \
    --cc=linux-crypto@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=michael@walle$(echo .)cc \
    --cc=paul.gortmaker@windriver$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox