* [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)
@ 2012-03-09 19:58 Paul Gortmaker
2012-03-11 1:42 ` Jason Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Paul Gortmaker @ 2012-03-09 19:58 UTC (permalink / raw)
To: michael, jason; +Cc: linux-crypto, linux-next, Paul Gortmaker
Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next)
"ARM: kirkwood: mv_cesa devicetree bindings"
fails to compile as follows:
CC drivers/crypto/mv_cesa.o
drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr'
drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function)
drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant
drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table')
because it is missing the linux/of.h header file.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
index b7a3d48..093e214 100644
--- a/drivers/crypto/mv_cesa.c
+++ b/drivers/crypto/mv_cesa.c
@@ -10,6 +10,7 @@
#include <crypto/algapi.h>
#include <linux/crypto.h>
#include <linux/interrupt.h>
+#include <linux/of.h>
#include <linux/io.h>
#include <linux/kthread.h>
#include <linux/platform_device.h>
--
1.7.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header) 2012-03-09 19:58 [PATCH] crypto: fix build failure in mv_cesa.c (missing of header) Paul Gortmaker @ 2012-03-11 1:42 ` Jason Cooper 2012-03-11 16:17 ` Paul Gortmaker 0 siblings, 1 reply; 4+ messages in thread From: Jason Cooper @ 2012-03-11 1:42 UTC (permalink / raw) To: Paul Gortmaker; +Cc: michael, linux-crypto, linux-next On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote: > Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next) > > "ARM: kirkwood: mv_cesa devicetree bindings" > > fails to compile as follows: > > CC drivers/crypto/mv_cesa.o > drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr' > drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function) > drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant > drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table') > > because it is missing the linux/of.h header file. > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com> Paul, Thanks for the patch. Unfortunately, I'm not learning fast enough. ;-) This series has been in a lot of flux lately, as you've experienced. The good news is, after talking with Olaf and Arnd, I think I have a good workflow figured out. Hopefully, failures like this won't happen in the future. As an fyi, I'm probably going to take kirkwood_dt_staging down (or, label it broken ;-) ) I intended it as a publicly viewable branch of "what's coming down the pipe", but it's not working out the way I intended. As for mv_cesa, it's next on my list. As soon as I figure out the irq stuff. Thanks for testing. Jason. > > diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c > index b7a3d48..093e214 100644 > --- a/drivers/crypto/mv_cesa.c > +++ b/drivers/crypto/mv_cesa.c > @@ -10,6 +10,7 @@ > #include <crypto/algapi.h> > #include <linux/crypto.h> > #include <linux/interrupt.h> > +#include <linux/of.h> > #include <linux/io.h> > #include <linux/kthread.h> > #include <linux/platform_device.h> > -- > 1.7.9.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header) 2012-03-11 1:42 ` Jason Cooper @ 2012-03-11 16:17 ` Paul Gortmaker 2012-03-12 2:32 ` Jason 0 siblings, 1 reply; 4+ messages in thread From: Paul Gortmaker @ 2012-03-11 16:17 UTC (permalink / raw) To: Jason Cooper; +Cc: michael, linux-crypto, linux-next On Sat, Mar 10, 2012 at 8:42 PM, Jason Cooper <jason@lakedaemon•net> wrote: > On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote: >> Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next) >> >> "ARM: kirkwood: mv_cesa devicetree bindings" >> >> fails to compile as follows: >> >> CC drivers/crypto/mv_cesa.o >> drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr' >> drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function) >> drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant >> drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table') >> >> because it is missing the linux/of.h header file. >> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com> > > Paul, > > Thanks for the patch. Unfortunately, I'm not learning fast enough. ;-) > This series has been in a lot of flux lately, as you've experienced. > > The good news is, after talking with Olaf and Arnd, I think I have a > good workflow figured out. Hopefully, failures like this won't happen > in the future. Sounds good -- don't be too hard on yourself wrt. a minor breakage. Feel free to just squish the above patch into whatever updates you have going. I don't see it needing to exist as a standalone commit. THanks, Paul. -- > > As an fyi, I'm probably going to take kirkwood_dt_staging down (or, label > it broken ;-) ) I intended it as a publicly viewable branch of "what's > coming down the pipe", but it's not working out the way I intended. > > As for mv_cesa, it's next on my list. As soon as I figure out the irq > stuff. > > Thanks for testing. > > Jason. > >> >> diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c >> index b7a3d48..093e214 100644 >> --- a/drivers/crypto/mv_cesa.c >> +++ b/drivers/crypto/mv_cesa.c >> @@ -10,6 +10,7 @@ >> #include <crypto/algapi.h> >> #include <linux/crypto.h> >> #include <linux/interrupt.h> >> +#include <linux/of.h> >> #include <linux/io.h> >> #include <linux/kthread.h> >> #include <linux/platform_device.h> >> -- >> 1.7.9.1 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo@vger•kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header) 2012-03-11 16:17 ` Paul Gortmaker @ 2012-03-12 2:32 ` Jason 0 siblings, 0 replies; 4+ messages in thread From: Jason @ 2012-03-12 2:32 UTC (permalink / raw) To: Paul Gortmaker; +Cc: michael, linux-crypto, linux-next On Sun, Mar 11, 2012 at 12:17:29PM -0400, Paul Gortmaker wrote: > On Sat, Mar 10, 2012 at 8:42 PM, Jason Cooper <jason@lakedaemon•net> wrote: > > On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote: > >> Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next) > >> > >> "ARM: kirkwood: mv_cesa devicetree bindings" > >> > >> fails to compile as follows: > >> > >> CC drivers/crypto/mv_cesa.o > >> drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr' > >> drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function) > >> drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant > >> drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table') > >> > >> because it is missing the linux/of.h header file. > >> > >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com> > > > > Paul, > > > > Thanks for the patch. Unfortunately, I'm not learning fast enough. ;-) > > This series has been in a lot of flux lately, as you've experienced. > > > > The good news is, after talking with Olaf and Arnd, I think I have a > > good workflow figured out. Hopefully, failures like this won't happen > > in the future. > > Sounds good -- don't be too hard on yourself wrt. a minor breakage. > Feel free to just squish the above patch into whatever updates you > have going. I don't see it needing to exist as a standalone commit. Thanks, it's definitely better that it be squashed into the existing commit. I wouldn't want a bisect to land in between it down the road. thx, Jason. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-12 2:32 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-03-09 19:58 [PATCH] crypto: fix build failure in mv_cesa.c (missing of header) Paul Gortmaker 2012-03-11 1:42 ` Jason Cooper 2012-03-11 16:17 ` Paul Gortmaker 2012-03-12 2:32 ` Jason
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox