From: Wim Van Sebroeck <wim@iguana•be>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: linus.walleij@stericsson•com, linux-watchdog@vger•kernel.org,
linux-next@vger•kernel.org
Subject: Re: Commit "watchdog: coh901327_wdt.c: fix timeout" breaks linux-next
Date: Mon, 26 Mar 2012 10:27:17 +0200 [thread overview]
Message-ID: <20120326082717.GX10698@spo001.leaseweb.com> (raw)
In-Reply-To: <CAP=VYLr4MfkBpgg-QeMRw9oDswtrySBEb6ZUKa8_CLOHh+pF2A@mail.gmail.com>
Hi Paul,
Will fix it.
Kind regards,
wim.
> Hi Wim,
>
> Can you please re-check this commit? It has two instances of
> the typo "timout" and one of them is causing a build failure
> in linux-next.
>
> Thanks,
> Paul.
> --
>
> drivers/watchdog/coh901327_wdt.c:358:15: error: 'struct
> watchdog_device' has no member named 'timout'
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/5940810/
>
> commit 884f1a12c8b39721452f0dfedf1f82de3d696cf1
> Author: Wim Van Sebroeck <wim@iguana•be>
> Date: Thu Mar 22 20:42:16 2012 +0100
>
> watchdog: coh901327_wdt.c: fix timeout
>
> Set the timeout value properly so that we don't get faulty values
> for the WDIOC_GETTIMEOUT iotcl. 'margin' should be an unsigned int.
> Also add a check to see if margin is a valid parameter after it is
> loaded as a module.
prev parent reply other threads:[~2012-03-26 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 14:32 Commit "watchdog: coh901327_wdt.c: fix timeout" breaks linux-next Paul Gortmaker
2012-03-26 8:27 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326082717.GX10698@spo001.leaseweb.com \
--to=wim@iguana$(echo .)be \
--cc=linus.walleij@stericsson$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox