* Commit "watchdog: coh901327_wdt.c: fix timeout" breaks linux-next
@ 2012-03-24 14:32 Paul Gortmaker
2012-03-26 8:27 ` Wim Van Sebroeck
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2012-03-24 14:32 UTC (permalink / raw)
To: wim, linus.walleij; +Cc: linux-watchdog, linux-next
Hi Wim,
Can you please re-check this commit? It has two instances of
the typo "timout" and one of them is causing a build failure
in linux-next.
Thanks,
Paul.
--
drivers/watchdog/coh901327_wdt.c:358:15: error: 'struct
watchdog_device' has no member named 'timout'
http://kisskb.ellerman.id.au/kisskb/buildresult/5940810/
commit 884f1a12c8b39721452f0dfedf1f82de3d696cf1
Author: Wim Van Sebroeck <wim@iguana•be>
Date: Thu Mar 22 20:42:16 2012 +0100
watchdog: coh901327_wdt.c: fix timeout
Set the timeout value properly so that we don't get faulty values
for the WDIOC_GETTIMEOUT iotcl. 'margin' should be an unsigned int.
Also add a check to see if margin is a valid parameter after it is
loaded as a module.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Commit "watchdog: coh901327_wdt.c: fix timeout" breaks linux-next
2012-03-24 14:32 Commit "watchdog: coh901327_wdt.c: fix timeout" breaks linux-next Paul Gortmaker
@ 2012-03-26 8:27 ` Wim Van Sebroeck
0 siblings, 0 replies; 2+ messages in thread
From: Wim Van Sebroeck @ 2012-03-26 8:27 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linus.walleij, linux-watchdog, linux-next
Hi Paul,
Will fix it.
Kind regards,
wim.
> Hi Wim,
>
> Can you please re-check this commit? It has two instances of
> the typo "timout" and one of them is causing a build failure
> in linux-next.
>
> Thanks,
> Paul.
> --
>
> drivers/watchdog/coh901327_wdt.c:358:15: error: 'struct
> watchdog_device' has no member named 'timout'
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/5940810/
>
> commit 884f1a12c8b39721452f0dfedf1f82de3d696cf1
> Author: Wim Van Sebroeck <wim@iguana•be>
> Date: Thu Mar 22 20:42:16 2012 +0100
>
> watchdog: coh901327_wdt.c: fix timeout
>
> Set the timeout value properly so that we don't get faulty values
> for the WDIOC_GETTIMEOUT iotcl. 'margin' should be an unsigned int.
> Also add a check to see if margin is a valid parameter after it is
> loaded as a module.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-26 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-24 14:32 Commit "watchdog: coh901327_wdt.c: fix timeout" breaks linux-next Paul Gortmaker
2012-03-26 8:27 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox