From: Richard Guy Briggs <rgb@redhat•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Eric Paris <eparis@redhat•com>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
sparclinux@vger•kernel.org
Subject: Re: linux-next: build failure after merge of the audit tree
Date: Tue, 22 Apr 2014 11:56:42 -0400 [thread overview]
Message-ID: <20140422155642.GA20182@madcap2.tricolour.ca> (raw)
In-Reply-To: <20140422162207.55e3d9f09244de281b9798cc@canb.auug.org.au>
On 14/04/22, Stephen Rothwell wrote:
> Hi Eric,
>
> After merging the audit tree, today's linux-next build (sparc defconfig)
> failed like this:
>
> In file included from include/linux/audit.h:29:0,
> from mm/mmap.c:33:
> arch/sparc/include/asm/syscall.h: In function 'syscall_get_arch':
> arch/sparc/include/asm/syscall.h:131:9: error: 'TIF_32BIT' undeclared (first use in this function)
> arch/sparc/include/asm/syscall.h:131:9: note: each undeclared identifier is reported only once for each function it appears in
>
> And many more ...
>
> Caused by commit 374c0c054122 ("ARCH: AUDIT: implement syscall_get_arch
> for all arches").
>
> I applied this patch for today:
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Tue, 22 Apr 2014 16:18:53 +1000
> Subject: [PATCH] fix ARCH: AUDIT: implement syscall_get_arch for all arches
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
Looks good to me. Thanks.
Acked-by: Richard Guy Briggs <rgb@redhat•com>
> ---
> arch/sparc/include/asm/syscall.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/sparc/include/asm/syscall.h b/arch/sparc/include/asm/syscall.h
> index fed3d511b108..a5a8153766b3 100644
> --- a/arch/sparc/include/asm/syscall.h
> +++ b/arch/sparc/include/asm/syscall.h
> @@ -128,8 +128,12 @@ static inline void syscall_set_arguments(struct task_struct *task,
>
> static inline int syscall_get_arch(void)
> {
> +#if defined(__sparc__) && defined(__arch64__)
> return test_thread_flag(TIF_32BIT) ? AUDIT_ARCH_SPARC
> : AUDIT_ARCH_SPARC64;
> +#else
> + return AUDIT_ARCH_SPARC;
> +#endif
> }
>
> #endif /* __ASM_SPARC_SYSCALL_H */
> --
> 1.9.2
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
- RGB
--
Richard Guy Briggs <rbriggs@redhat•com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
next prev parent reply other threads:[~2014-04-22 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 6:22 linux-next: build failure after merge of the audit tree Stephen Rothwell
2014-04-22 15:56 ` Richard Guy Briggs [this message]
2014-04-22 16:32 ` Eric Paris
2014-04-22 21:27 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2013-11-06 6:27 Stephen Rothwell
2013-11-06 16:54 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422155642.GA20182@madcap2.tricolour.ca \
--to=rgb@redhat$(echo .)com \
--cc=eparis@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sparclinux@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox