public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
* [PATCH linux-next] ARM: mvebu: Fix pmsu compilation when ARMv6 is selected
@ 2014-05-06 20:23 Vincent Stehlé
  2014-05-08 17:05 ` Jason Cooper
  0 siblings, 1 reply; 2+ messages in thread
From: Vincent Stehlé @ 2014-05-06 20:23 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, linux-next
  Cc: Andrew Lunn, Russell King, Jason Cooper, Vincent Stehlé,
	Gregory Clement, Sebastian Hesselbarth

When compiling for multiplatform for both ARMv6 and ARMv7, the default compiler
flags are for ARMv6, and we will get:

  /tmp/ccwDEzd0.s: Assembler messages:
  /tmp/ccwDEzd0.s:639: Error: selected processor does not support ARM mode `isb '
  /tmp/ccwDEzd0.s:645: Error: selected processor does not support ARM mode `isb '
  /tmp/ccwDEzd0.s:646: Error: selected processor does not support ARM mode `dsb '
  /tmp/ccwDEzd0.s:695: Error: selected processor does not support ARM mode `isb '
  make[1]: *** [arch/arm/mach-mvebu/pmsu.o] Error 1

Fix this in a similar manner than done previously in commit
72533b77d30c2be02672e26b5dde1263d7b4c2be, by specifying ARMv7 flags for pmsu.o.

Signed-off-by: Vincent Stehlé <vincent.stehle@laposte•net>
Cc: Jason Cooper <jason@lakedaemon•net>
Cc: Andrew Lunn <andrew@lunn•ch>
Cc: Gregory Clement <gregory.clement@free-electrons•com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Cc: Russell King <linux@arm•linux.org.uk>
---

Hi,

This build issue can be seen with e.g. Linux next-20140506, ARCH=arm and
allmodconfig.

Best regards,

V.

 arch/arm/mach-mvebu/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index 854b72a..2ecb828 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -2,6 +2,7 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \
 	-I$(srctree)/arch/arm/plat-orion/include
 
 AFLAGS_coherency_ll.o		:= -Wa,-march=armv7-a
+CFLAGS_pmsu.o			:= -march=armv7-a
 
 obj-y				 += system-controller.o mvebu-soc-id.o
 
-- 
1.9.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] ARM: mvebu: Fix pmsu compilation when ARMv6 is selected
  2014-05-06 20:23 [PATCH linux-next] ARM: mvebu: Fix pmsu compilation when ARMv6 is selected Vincent Stehlé
@ 2014-05-08 17:05 ` Jason Cooper
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2014-05-08 17:05 UTC (permalink / raw)
  To: Vincent Stehlé
  Cc: linux-arm-kernel, linux-kernel, linux-next, Andrew Lunn,
	Gregory Clement, Sebastian Hesselbarth, Russell King

On Tue, May 06, 2014 at 10:23:02PM +0200, Vincent Stehlé wrote:
> When compiling for multiplatform for both ARMv6 and ARMv7, the default compiler
> flags are for ARMv6, and we will get:
> 
>   /tmp/ccwDEzd0.s: Assembler messages:
>   /tmp/ccwDEzd0.s:639: Error: selected processor does not support ARM mode `isb '
>   /tmp/ccwDEzd0.s:645: Error: selected processor does not support ARM mode `isb '
>   /tmp/ccwDEzd0.s:646: Error: selected processor does not support ARM mode `dsb '
>   /tmp/ccwDEzd0.s:695: Error: selected processor does not support ARM mode `isb '
>   make[1]: *** [arch/arm/mach-mvebu/pmsu.o] Error 1
> 
> Fix this in a similar manner than done previously in commit
> 72533b77d30c2be02672e26b5dde1263d7b4c2be, by specifying ARMv7 flags for pmsu.o.
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte•net>
> Cc: Jason Cooper <jason@lakedaemon•net>
> Cc: Andrew Lunn <andrew@lunn•ch>
> Cc: Gregory Clement <gregory.clement@free-electrons•com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
> Cc: Russell King <linux@arm•linux.org.uk>
> ---
> 
> Hi,
> 
> This build issue can be seen with e.g. Linux next-20140506, ARCH=arm and
> allmodconfig.
> 
> Best regards,
> 
> V.
> 
>  arch/arm/mach-mvebu/Makefile | 1 +
>  1 file changed, 1 insertion(+)

Applied to mvebu/soc, thanks!

thx,

Jason.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-08 17:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 20:23 [PATCH linux-next] ARM: mvebu: Fix pmsu compilation when ARMv6 is selected Vincent Stehlé
2014-05-08 17:05 ` Jason Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox