From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Stephan Mueller <smueller@chronox•de>
Cc: Herbert Xu <herbert@gondor•apana.org.au>,
kbuild test robot <fengguang.wu@intel•com>,
kbuild@01•org, Dan Carpenter <dan.carpenter@oracle•com>,
linux-crypto@vger•kernel.org,
Randy Dunlap <rdunlap@infradead•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros
Date: Sun, 29 Jun 2014 12:20:15 +1000 [thread overview]
Message-ID: <20140629122015.43f5178a@canb.auug.org.au> (raw)
In-Reply-To: <1949550.LXKdkPOvgm@myon.chronox.de>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
Hi Stephan,
On Sat, 28 Jun 2014 22:00:07 +0200 Stephan Mueller <smueller@chronox•de> wrote:
>
> diff --git a/crypto/drbg.c b/crypto/drbg.c
> index 6679a26..03a230e 100644
> --- a/crypto/drbg.c
> +++ b/crypto/drbg.c
> @@ -102,8 +102,13 @@
> #if !defined(CONFIG_CRYPTO_DRBG_HASH) && \
> !defined(CONFIG_CRYPTO_DRBG_HMAC) && \
> !defined(CONFIG_CRYPTO_DRBG_CTR)
> -#warning "The DRBG code is useless without compiling at least one DRBG type"
> -#endif
> +#define CRYPTO_DRBG_NONE_STRING "none "
> +static int __init drbg_init(void)
> +{
> + pr_warn("DRBG: no DRBG core was compiled!\n");
> + return -EFAULT;
> +}
> +#else
Wouldn't this be better handled by Kconfig so that we don't even try to
build this unless one of the required core modules is chosen?
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-29 2:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 19:57 [PATCH 0/4] DRBG: Fixes for sparse tool reports Stephan Mueller
2014-06-28 19:58 ` [PATCH 1/4] DRBG: use of kernel linked list Stephan Mueller
2014-07-04 14:11 ` Herbert Xu
2014-06-28 20:00 ` [PATCH 2/4] DRBG: cleanup of preprocessor macros Stephan Mueller
2014-06-29 2:20 ` Stephen Rothwell [this message]
2014-06-29 5:07 ` Stephan Mueller
2014-06-29 7:41 ` Randy Dunlap
2014-06-29 11:37 ` Stephan Mueller
2014-07-04 14:15 ` Herbert Xu
2014-07-05 0:03 ` Stephan Mueller
2014-06-28 20:01 ` [PATCH 3/4] DRBG: Fix format string for debugging statements Stephan Mueller
2014-06-29 2:24 ` Stephen Rothwell
2014-06-29 3:46 ` Stephan Mueller
2014-06-29 3:53 ` Joe Perches
2014-06-29 4:54 ` Stephan Mueller
2014-07-04 11:21 ` Dan Carpenter
2014-07-04 16:57 ` Joe Perches
2014-07-04 23:57 ` Stephan Mueller
2014-07-05 0:09 ` Joe Perches
2014-07-05 0:15 ` Stephan Mueller
2014-07-05 0:24 ` Joe Perches
2014-07-05 0:27 ` Stephan Mueller
2014-06-28 20:04 ` [PATCH 4/4] DRBG: Call CTR DRBG DF function only once Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140629122015.43f5178a@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=kbuild@01$(echo .)org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=smueller@chronox$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox