public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Stephan Mueller <smueller@chronox•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Herbert Xu <herbert@gondor•apana.org.au>,
	kbuild test robot <fengguang.wu@intel•com>,
	kbuild@01•org, Dan Carpenter <dan.carpenter@oracle•com>,
	linux-crypto@vger•kernel.org,
	Randy Dunlap <rdunlap@infradead•org>,
	linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 2/4] DRBG: cleanup of preprocessor macros
Date: Sun, 29 Jun 2014 07:07:19 +0200	[thread overview]
Message-ID: <3104100.drOBnqUFp8@myon.chronox.de> (raw)
In-Reply-To: <20140629122015.43f5178a@canb.auug.org.au>

Am Sonntag, 29. Juni 2014, 12:20:15 schrieb Stephen Rothwell:

Hi Stephen,

> Hi Stephan,
> 
> On Sat, 28 Jun 2014 22:00:07 +0200 Stephan Mueller <smueller@chronox•de> 
wrote:
> > diff --git a/crypto/drbg.c b/crypto/drbg.c
> > index 6679a26..03a230e 100644
> > --- a/crypto/drbg.c
> > +++ b/crypto/drbg.c
> > @@ -102,8 +102,13 @@
> > 
> >  #if !defined(CONFIG_CRYPTO_DRBG_HASH) && \
> >  
> >  	!defined(CONFIG_CRYPTO_DRBG_HMAC) && \
> >  	!defined(CONFIG_CRYPTO_DRBG_CTR)
> > 
> > -#warning "The DRBG code is useless without compiling at least one DRBG
> > type" -#endif
> > +#define CRYPTO_DRBG_NONE_STRING "none "
> > +static int __init drbg_init(void)
> > +{
> > +	pr_warn("DRBG: no DRBG core was compiled!\n");
> > +	return -EFAULT;
> > +}
> > +#else
> 
> Wouldn't this be better handled by Kconfig so that we don't even try to
> build this unless one of the required core modules is chosen?

I tried that, but it seems that my Kconfig Foo is not too well: adding the 
DRBG cores to the depends line of CRYPTO_DRBG as indicated in the following, I 
have a circular dependency. With that circular dependency, the DRBG entries do 
not show up in make menuconfig.

menuconfig CRYTPO_DRBG
        tristate "NIST SP800-90A DRBG"
        depends on CRYPTO && (CRYPTO_DRBG_HMAC || CRYPTO_DRBG_CTR || 
CRYPTO_DRBG_HASH)
...

if CRYTPO_DRBG

config CRYPTO_DRBG_HMAC
        bool "Enable HMAC DRBG"
        default y
        depends on CRYTPO_DRBG

Do you have a working solution in mind? The goal is that once CRYPTO_DRBG is 
selected, at least one of the DRBG cores must be selected.

Thanks
Stephan
-- 
| Cui bono? |

next prev parent reply	other threads:[~2014-06-29  5:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-28 19:57 [PATCH 0/4] DRBG: Fixes for sparse tool reports Stephan Mueller
2014-06-28 19:58 ` [PATCH 1/4] DRBG: use of kernel linked list Stephan Mueller
2014-07-04 14:11   ` Herbert Xu
2014-06-28 20:00 ` [PATCH 2/4] DRBG: cleanup of preprocessor macros Stephan Mueller
2014-06-29  2:20   ` Stephen Rothwell
2014-06-29  5:07     ` Stephan Mueller [this message]
2014-06-29  7:41       ` Randy Dunlap
2014-06-29 11:37         ` Stephan Mueller
2014-07-04 14:15           ` Herbert Xu
2014-07-05  0:03             ` Stephan Mueller
2014-06-28 20:01 ` [PATCH 3/4] DRBG: Fix format string for debugging statements Stephan Mueller
2014-06-29  2:24   ` Stephen Rothwell
2014-06-29  3:46     ` Stephan Mueller
2014-06-29  3:53       ` Joe Perches
2014-06-29  4:54         ` Stephan Mueller
2014-07-04 11:21         ` Dan Carpenter
2014-07-04 16:57           ` Joe Perches
2014-07-04 23:57             ` Stephan Mueller
2014-07-05  0:09               ` Joe Perches
2014-07-05  0:15                 ` Stephan Mueller
2014-07-05  0:24                   ` Joe Perches
2014-07-05  0:27                     ` Stephan Mueller
2014-06-28 20:04 ` [PATCH 4/4] DRBG: Call CTR DRBG DF function only once Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3104100.drOBnqUFp8@myon.chronox.de \
    --to=smueller@chronox$(echo .)de \
    --cc=dan.carpenter@oracle$(echo .)com \
    --cc=fengguang.wu@intel$(echo .)com \
    --cc=herbert@gondor$(echo .)apana.org.au \
    --cc=kbuild@01$(echo .)org \
    --cc=linux-crypto@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=rdunlap@infradead$(echo .)org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox