* linux-next: build warnings after merge of the regulator tree
@ 2014-07-28 10:32 Stephen Rothwell
2014-07-28 13:49 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2014-07-28 10:32 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Tuomas Tynkkynen
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
Hi all,
After merging the regulator tree, today's linux-next build (i386
defconfig among others) produced these warnings:
In file included from include/linux/regulator/machine.h:18:0,
from drivers/acpi/bus.c:36:
include/linux/regulator/consumer.h:468:23: warning: 'regulator_get_regmap' defined but not used [-Wunused-function]
static struct regmap *regulator_get_regmap(struct regulator *regulator)
^
include/linux/regulator/consumer.h:473:12: warning: 'regulator_get_hardware_vsel_register' defined but not used [-Wunused-function]
static int regulator_get_hardware_vsel_register(struct regulator *regulator,
^
include/linux/regulator/consumer.h:480:12: warning: 'regulator_list_hardware_vsel' defined but not used [-Wunused-function]
static int regulator_list_hardware_vsel(struct regulator *regulator,
^
And more like that.
Introduced by commit 04eca28cde52 ("regulator: Add helpers for
low-level register access"). Missing "static inline"s ... I suspect
this is becoming more common due to the lack of "extern"s in our header
files now. :-(
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: build warnings after merge of the regulator tree
2014-07-28 10:32 linux-next: build warnings after merge of the regulator tree Stephen Rothwell
@ 2014-07-28 13:49 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-07-28 13:49 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Liam Girdwood, linux-next, linux-kernel, Tuomas Tynkkynen
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
On Mon, Jul 28, 2014 at 08:32:33PM +1000, Stephen Rothwell wrote:
> In file included from include/linux/regulator/machine.h:18:0,
> from drivers/acpi/bus.c:36:
> include/linux/regulator/consumer.h:468:23: warning: 'regulator_get_regmap' defined but not used [-Wunused-function]
> static struct regmap *regulator_get_regmap(struct regulator *regulator)
> ^
Ugh, that should actually be fixed but apparently I forgot to rebuild my
-next branch before you picked it up. Should be fine tomorrow anyway,
sorry.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-28 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-28 10:32 linux-next: build warnings after merge of the regulator tree Stephen Rothwell
2014-07-28 13:49 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox