From: Jason Cooper <jason@lakedaemon•net>
To: Christoph Lameter <cl@linux•com>
Cc: Thomas Gleixner <tglx@linutronix•de>, Tejun Heo <tj@kernel•org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
Mark Brown <broonie@kernel•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
nicolas.pitre@linaro•org,
Russell King <rmk+kernel@arm•linux.org.uk>,
Kyungmin Park <kyungmin.park@samsung•com>
Subject: Re: linux-next: Tree for Sep 1
Date: Wed, 10 Sep 2014 11:04:47 -0400 [thread overview]
Message-ID: <20140910150447.GV30828@titan.lakedaemon.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1409100914180.23942@gentwo.org>
Christoph,
On Wed, Sep 10, 2014 at 09:15:30AM -0500, Christoph Lameter wrote:
> On Tue, 9 Sep 2014, Tejun Heo wrote:
> > On Fri, Sep 05, 2014 at 02:11:23AM +0900, Tejun Heo wrote:
> > > On Tue, Sep 02, 2014 at 10:00:07AM -0500, Christoph Lameter wrote:
> > > > Subject: irqchip: Properly fetch the per cpu offset
> > > >
> > > > The raw_cpu_read() conversion dropped the fetch of the offset
> > > > from base->percpu_base in gic_get_percpu_base.
> > > >
> > > > Signed-off-by: Christoph Lameter <cl@linux•com>
> > > >
> > > > Index: linux/drivers/irqchip/irq-gic.c
> > > > ===================================================================
> > > > --- linux.orig/drivers/irqchip/irq-gic.c
> > > > +++ linux/drivers/irqchip/irq-gic.c
> > > > @@ -102,7 +102,7 @@ static struct gic_chip_data gic_data[MAX
> > > > #ifdef CONFIG_GIC_NON_BANKED
> > > > static void __iomem *gic_get_percpu_base(union gic_base *base)
> > > > {
> > > > - return raw_cpu_read(base->percpu_base);
> > > > + return raw_cpu_read(*base->percpu_base);
> > >
> > > I suppose this should go through percpu/for-3.18-consistent-ops? Can
> > > we please cc irq folks and get acks?
> >
> > Christoph, please drive this forward.
>
> CCing IRQ subsystem and IRQCHIP drivers maintainers.
Thanks Chris. I'm a bit behind on irqchip stuff, so I may have missed
something here... Did we get Cc'd on the original patch that caused the
regression? I'm fairly certain I haven't seen it to Ack it.
It wouldn't be an issue worth mentioning if it were a vendor-specific
driver, however, the gic is used by damn near every major ARM SoC.
Tejun (I think) was kind enough to post the links to the email
thread for the original patch, so I'll try to get to this soon-ish.
thx,
Jason.
next prev parent reply other threads:[~2014-09-10 15:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 23:07 linux-next: Tree for Sep 1 Mark Brown
2014-09-02 13:16 ` Bartlomiej Zolnierkiewicz
2014-09-02 13:19 ` Bartlomiej Zolnierkiewicz
2014-09-02 14:07 ` Christoph Lameter
2014-09-02 15:00 ` Christoph Lameter
2014-09-03 16:09 ` Bartlomiej Zolnierkiewicz
2014-09-04 17:11 ` Tejun Heo
2014-09-04 17:59 ` Christoph Lameter
2014-09-05 18:17 ` Russell King - ARM Linux
2014-09-05 11:31 ` Jason Cooper
2014-09-05 23:48 ` Tejun Heo
2014-09-09 0:37 ` Tejun Heo
2014-09-10 14:15 ` Christoph Lameter
2014-09-10 15:04 ` Jason Cooper [this message]
2014-09-10 16:18 ` Nicolas Pitre
2014-09-10 16:21 ` Christoph Lameter
2014-09-10 16:19 ` Christoph Lameter
2014-09-05 19:27 ` Nicolas Pitre
2014-09-08 14:15 ` Christoph Lameter
2014-09-10 17:41 ` Russell King - ARM Linux
2014-09-10 17:59 ` Nicolas Pitre
2014-09-11 10:24 ` Bartlomiej Zolnierkiewicz
2014-09-10 18:11 ` Marc Zyngier
2014-09-11 11:01 ` Bartlomiej Zolnierkiewicz
2014-09-11 11:17 ` Marc Zyngier
2014-09-14 5:40 ` Jason Cooper
2014-09-18 12:51 ` Bartlomiej Zolnierkiewicz
2014-09-19 3:52 ` Tejun Heo
2014-09-02 14:58 ` Jason Cooper
-- strict thread matches above, loose matches on Subject: below --
2015-09-01 8:21 Stephen Rothwell
2017-09-01 6:39 Stephen Rothwell
2021-09-01 8:17 Stephen Rothwell
2022-09-01 7:18 Stephen Rothwell
2025-09-01 5:08 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910150447.GV30828@titan.lakedaemon.net \
--to=jason@lakedaemon$(echo .)net \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=cl@linux$(echo .)com \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=nicolas.pitre@linaro$(echo .)org \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=tglx@linutronix$(echo .)de \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox