From: Christoph Lameter <cl@linux•com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>
Cc: Mark Brown <broonie@kernel•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
nicolas.pitre@linaro•org,
Russell King <rmk+kernel@arm•linux.org.uk>,
Tejun Heo <tj@kernel•org>,
Kyungmin Park <kyungmin.park@samsung•com>
Subject: Re: linux-next: Tree for Sep 1
Date: Tue, 2 Sep 2014 09:07:23 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1409020857110.9201@gentwo.org> (raw)
In-Reply-To: <1627064.QhxvejlWdk@amdc1032>
On Tue, 2 Sep 2014, Bartlomiej Zolnierkiewicz wrote:
> Commit 532d0d0690d1 ("irqchips: Replace __this_cpu_ptr uses")
> incorrectly converted *__this_cpu_ptr() to raw_cpu_read() instead
> of *raw_cpu_ptr(). Fix it.
Oww.. This is double indirection deal there. A percpu offset pointing to
a pointer?
Generally the following is true (definition from
include/asm-generic/percpu.h that is used for ARM for raw_cpu_read):
#define raw_cpu_read_4(pcp) (*raw_cpu_ptr(&(pcp)))
> Index: b/drivers/irqchip/irq-gic.c
> ===================================================================
> --- a/drivers/irqchip/irq-gic.c 2014-09-02 14:03:41.026758653 +0200
> +++ b/drivers/irqchip/irq-gic.c 2014-09-02 14:37:04.466811546 +0200
> @@ -102,7 +102,7 @@ static struct gic_chip_data gic_data[MAX
> #ifdef CONFIG_GIC_NON_BANKED
> static void __iomem *gic_get_percpu_base(union gic_base *base)
> {
> - return raw_cpu_read(base->percpu_base);
> + return *raw_cpu_ptr(base->percpu_base);
> }
>
> static void __iomem *gic_get_common_base(union gic_base *base)
>
>
next prev parent reply other threads:[~2014-09-02 14:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 23:07 linux-next: Tree for Sep 1 Mark Brown
2014-09-02 13:16 ` Bartlomiej Zolnierkiewicz
2014-09-02 13:19 ` Bartlomiej Zolnierkiewicz
2014-09-02 14:07 ` Christoph Lameter [this message]
2014-09-02 15:00 ` Christoph Lameter
2014-09-03 16:09 ` Bartlomiej Zolnierkiewicz
2014-09-04 17:11 ` Tejun Heo
2014-09-04 17:59 ` Christoph Lameter
2014-09-05 18:17 ` Russell King - ARM Linux
2014-09-05 11:31 ` Jason Cooper
2014-09-05 23:48 ` Tejun Heo
2014-09-09 0:37 ` Tejun Heo
2014-09-10 14:15 ` Christoph Lameter
2014-09-10 15:04 ` Jason Cooper
2014-09-10 16:18 ` Nicolas Pitre
2014-09-10 16:21 ` Christoph Lameter
2014-09-10 16:19 ` Christoph Lameter
2014-09-05 19:27 ` Nicolas Pitre
2014-09-08 14:15 ` Christoph Lameter
2014-09-10 17:41 ` Russell King - ARM Linux
2014-09-10 17:59 ` Nicolas Pitre
2014-09-11 10:24 ` Bartlomiej Zolnierkiewicz
2014-09-10 18:11 ` Marc Zyngier
2014-09-11 11:01 ` Bartlomiej Zolnierkiewicz
2014-09-11 11:17 ` Marc Zyngier
2014-09-14 5:40 ` Jason Cooper
2014-09-18 12:51 ` Bartlomiej Zolnierkiewicz
2014-09-19 3:52 ` Tejun Heo
2014-09-02 14:58 ` Jason Cooper
-- strict thread matches above, loose matches on Subject: below --
2015-09-01 8:21 Stephen Rothwell
2017-09-01 6:39 Stephen Rothwell
2021-09-01 8:17 Stephen Rothwell
2022-09-01 7:18 Stephen Rothwell
2025-09-01 5:08 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1409020857110.9201@gentwo.org \
--to=cl@linux$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=nicolas.pitre@linaro$(echo .)org \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox