From: Sebastian Schmidt <yath@yath•de>
To: Kees Cook <keescook@chromium•org>
Cc: "Luck, Tony" <tony.luck@intel•com>,
"ccross@android•com" <ccross@android•com>,
"anton@enomsg•org" <anton@enomsg•org>,
linux-kernel <linux-kernel@vger•kernel.org>,
linux-next <linux-next@vger•kernel.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Jim Davis <jim.epost@gmail•com>
Subject: Re: randconfig build error with next-20141113, in fs/pstore/inode.c
Date: Thu, 13 Nov 2014 21:09:34 -0800 [thread overview]
Message-ID: <20141114050934.GA7964@moniac.lan.yath.de> (raw)
In-Reply-To: <CAGXu5jLsd3G3+PCwFSUGDxxbfnJwx8G8X4chH0WK21-kv+_ecA@mail.gmail.com>
Hi all,
On Thu, Nov 13, 2014 at 11:21:18AM -0800, Kees Cook wrote:
> > This looks to come from your "Honor dmesg_restrict sysctl on dmesg dumps" patch
Oops, you are right.
> > The randconfig doesn't have CONFIG_PRINTK. I guess we need to provide a stub
> > in <linux/syslog.h> to cover this.
>
> Without CONFIG_PRINTK, check_syslog_permissions should probably fail.
Kees, I disagree. Without CONFIG_PRINTK, there isn't even a
dmesg_restrict sysctl, so there is no way to turn that on (AFAICS) and
we should retain the default behaviour.
I'll send a patch shortly.
Sebastian
next prev parent reply other threads:[~2014-11-14 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 14:52 randconfig build error with next-20141113, in fs/pstore/inode.c Jim Davis
2014-11-13 19:18 ` Luck, Tony
2014-11-13 19:21 ` Kees Cook
2014-11-14 5:09 ` Sebastian Schmidt [this message]
2014-11-14 5:22 ` [PATCH] syslog: provide stub check_syslog_permissions Sebastian Schmidt
2014-11-14 20:06 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114050934.GA7964@moniac.lan.yath.de \
--to=yath@yath$(echo .)de \
--cc=anton@enomsg$(echo .)org \
--cc=ccross@android$(echo .)com \
--cc=jim.epost@gmail$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tony.luck@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox