public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Sebastian Schmidt <yath@yath•de>
To: Anton Vorontsov <anton@enomsg•org>,
	Colin Cross <ccross@android•com>,
	Kees Cook <keescook@chromium•org>,
	Tony Luck <tony.luck@intel•com>
Cc: linux-kernel <linux-kernel@vger•kernel.org>,
	linux-next <linux-next@vger•kernel.org>,
	Stephen Rothwell <sfr@canb•auug.org.au>,
	Jim Davis <jim.epost@gmail•com>
Subject: [PATCH] syslog: provide stub check_syslog_permissions
Date: Thu, 13 Nov 2014 21:22:39 -0800	[thread overview]
Message-ID: <20141114052239.GB7964@moniac.lan.yath.de> (raw)
In-Reply-To: <20141114050934.GA7964@moniac.lan.yath.de>

When building without CONFIG_PRINTK, we need to provide a stub
check_syslog_permissions. As there is no way to turn on the
dmesg_restrict sysctl without CONFIG_PRINTK, return success.

Reported-by: Jim Davis <jim.epost@gmail•com>
Signed-off-by: Sebastian Schmidt <yath@yath•de>
---
 include/linux/syslog.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/linux/syslog.h b/include/linux/syslog.h
index 9def529..13c05d1 100644
--- a/include/linux/syslog.h
+++ b/include/linux/syslog.h
@@ -48,6 +48,14 @@
 #define SYSLOG_FROM_PROC             1
 
 int do_syslog(int type, char __user *buf, int count, bool from_file);
+
+#ifdef CONFIG_PRINTK
 int check_syslog_permissions(int type, bool from_file);
+#else
+static int check_syslog_permissions(int type, bool from_file)
+{
+	return 0;
+}
+#endif
 
 #endif /* _LINUX_SYSLOG_H */
-- 
2.1.1

  reply	other threads:[~2014-11-14  5:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 14:52 randconfig build error with next-20141113, in fs/pstore/inode.c Jim Davis
2014-11-13 19:18 ` Luck, Tony
2014-11-13 19:21   ` Kees Cook
2014-11-14  5:09     ` Sebastian Schmidt
2014-11-14  5:22       ` Sebastian Schmidt [this message]
2014-11-14 20:06         ` [PATCH] syslog: provide stub check_syslog_permissions Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141114052239.GB7964@moniac.lan.yath.de \
    --to=yath@yath$(echo .)de \
    --cc=anton@enomsg$(echo .)org \
    --cc=ccross@android$(echo .)com \
    --cc=jim.epost@gmail$(echo .)com \
    --cc=keescook@chromium$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=tony.luck@intel$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox