* linux-next: build warning after merge of the irqchip tree
@ 2014-11-27 6:28 Stephen Rothwell
2014-11-28 4:46 ` [PATCH] irqchip: gic: Remove warning by including linux/irqdomain.h Jason Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2014-11-27 6:28 UTC (permalink / raw)
To: Jason Cooper; +Cc: linux-next, linux-kernel, Suravee Suthikulpanit
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
Hi Jason,
After merging the irqchip tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
include/linux/irqchip/arm-gic.h:109:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from arch/arm/mach-ux500/pm.c:13:0:
include/linux/irqchip/arm-gic.h:109:53: warning: 'struct irq_domain' declared inside parameter list
int gicv2m_of_init(struct device_node *node, struct irq_domain *parent);
^
and many more similar.
Introduced by commit 853a33ce6932 ("irqchip: gic-v2m: Add support for
ARM GICv2m MSI(-X) doorbell").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] irqchip: gic: Remove warning by including linux/irqdomain.h
2014-11-27 6:28 linux-next: build warning after merge of the irqchip tree Stephen Rothwell
@ 2014-11-28 4:46 ` Jason Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2014-11-28 4:46 UTC (permalink / raw)
To: Stephen Rothwell, Marc Zyngier
Cc: linux-next, linux-kernel, Suravee Suthikulpanit, Thomas Gleixner
Commit
853a33ce6932 irqchip: gic-v2m: Add support for ARM GICv2m MSI(-X) doorbell
Introduced a series of warnings when building ARM multi_v7_defconfig:
include/linux/irqchip/arm-gic.h:109:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from arch/arm/mach-ux500/pm.c:13:0:
include/linux/irqchip/arm-gic.h:109:53: warning: 'struct irq_domain' declared inside parameter list
int gicv2m_of_init(struct device_node *node, struct irq_domain *parent);
^
Fix this by adding the proper include.
Signed-off-by: Jason Cooper <jason@lakedaemon•net>
---
I've added this to irqchip/irqdomain-arm locally and pushed it to next. If
there are no objections, I'll push it to irqchip/irqdomain-arm.
thx,
Jason.
include/linux/irqchip/arm-gic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/irqchip/arm-gic.h b/include/linux/irqchip/arm-gic.h
index 60b09ed58cae..d1b2263a4db3 100644
--- a/include/linux/irqchip/arm-gic.h
+++ b/include/linux/irqchip/arm-gic.h
@@ -10,6 +10,8 @@
#ifndef __LINUX_IRQCHIP_ARM_GIC_H
#define __LINUX_IRQCHIP_ARM_GIC_H
+#include <linux/irqdomain.h>
+
#define GIC_CPU_CTRL 0x00
#define GIC_CPU_PRIMASK 0x04
#define GIC_CPU_BINPOINT 0x08
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-28 4:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-27 6:28 linux-next: build warning after merge of the irqchip tree Stephen Rothwell
2014-11-28 4:46 ` [PATCH] irqchip: gic: Remove warning by including linux/irqdomain.h Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox