From: David Miller <davem@davemloft•net>
To: mail@rupran•de
Cc: jim.epost@gmail•com, sfr@canb•auug.org.au,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
jiri@resnulli•us, sfeldma@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig
Date: Thu, 04 Dec 2014 20:24:04 -0800 (PST) [thread overview]
Message-ID: <20141204.202404.32587724475591669.davem@davemloft.net> (raw)
In-Reply-To: <54809BA5.7030901@rupran.de>
From: Andreas Ruprecht <mail@rupran•de>
Date: Thu, 04 Dec 2014 18:36:37 +0100
> On 04.12.2014 17:34, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> drivers/built-in.o: In function `rocker_port_fdb_learn_work':
>> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3014: undefined
>> reference to `br_fdb_external_learn_del'
>> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3016: undefined
>> reference to `br_fdb_external_learn_add'
>>
>
> Hi,
>
> the problem here is that CONFIG_BRIDGE is set to 'm' (leading to
> inclusion of the two functions above in the kernel module) while
> CONFIG_ROCKER is set to 'y', requiring the functions at link time.
>
> Is the attached patch sufficient to fix this?
Do not use select, please.
You can only use select on leaf node Kconfig symbols, ie. those
which do not have any dependencies whatsoever.
Select does not recursively walk down the dependency chain turning
things on for you when you say "select X".
next prev parent reply other threads:[~2014-12-05 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 16:34 randconfig build error with next-20141204, in drivers/net/ethernet/rocker/rocker.c Jim Davis
2014-12-04 17:36 ` [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig Andreas Ruprecht
2014-12-04 18:15 ` Jiri Pirko
2014-12-05 4:24 ` David Miller [this message]
2014-12-05 8:28 ` Andreas Ruprecht
2014-12-05 8:32 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204.202404.32587724475591669.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=jim.epost@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mail@rupran$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox