From: Jiri Pirko <jiri@resnulli•us>
To: Andreas Ruprecht <mail@rupran•de>
Cc: Jim Davis <jim.epost@gmail•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next <linux-next@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>,
sfeldma@gmail•com, netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig
Date: Thu, 4 Dec 2014 19:15:48 +0100 [thread overview]
Message-ID: <20141204181548.GH1861@nanopsycho.orion> (raw)
In-Reply-To: <54809BA5.7030901@rupran.de>
Thu, Dec 04, 2014 at 06:36:37PM CET, mail@rupran•de wrote:
>On 04.12.2014 17:34, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> drivers/built-in.o: In function `rocker_port_fdb_learn_work':
>> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3014: undefined
>> reference to `br_fdb_external_learn_del'
>> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3016: undefined
>> reference to `br_fdb_external_learn_add'
>>
>
>Hi,
>
>the problem here is that CONFIG_BRIDGE is set to 'm' (leading to
>inclusion of the two functions above in the kernel module) while
>CONFIG_ROCKER is set to 'y', requiring the functions at link time.
>
>Is the attached patch sufficient to fix this?
>
>Regards,
>
>Andreas
>From 0529c3cbe381338dc3337e07a71e15b3d22a3255 Mon Sep 17 00:00:00 2001
>From: Andreas Ruprecht <rupran@einserver•de>
>Date: Thu, 4 Dec 2014 18:28:09 +0100
>Subject: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig
>
>In a configuration with CONFIG_BRIDGE set to 'm' and CONFIG_ROCKER
>set to 'y', undefined references occur at link time:
>
>> drivers/built-in.o: In function `rocker_port_fdb_learn_work':
>> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3014: undefined
>> reference to `br_fdb_external_learn_del'
>> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3016: undefined
>> reference to `br_fdb_external_learn_add'
>
>This patch fixes these by selecting CONFIG_BRIDGE from CONFIG_ROCKER.
>
>Reported-by: Jim Davis <jim.epost@gmail•com>
>Signed-off-by: Andreas Ruprecht <rupran@einserver•de>
Acked-by: Jiri Pirko <jiri@resnulli•us>
this is ok for now. There is a plan to replace
br_fdb_external_learn_add/del a by notifier which will fix this as well.
Thanks.
>---
> drivers/net/ethernet/rocker/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ethernet/rocker/Kconfig b/drivers/net/ethernet/rocker/Kconfig
>index 11a850eab628..ade10ec4c78d 100644
>--- a/drivers/net/ethernet/rocker/Kconfig
>+++ b/drivers/net/ethernet/rocker/Kconfig
>@@ -18,6 +18,7 @@ if NET_VENDOR_ROCKER
> config ROCKER
> tristate "Rocker switch driver (EXPERIMENTAL)"
> depends on PCI && NET_SWITCHDEV
>+ select BRIDGE
> ---help---
> This driver supports Rocker switch device.
>
>--
>1.9.1
>
next prev parent reply other threads:[~2014-12-04 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 16:34 randconfig build error with next-20141204, in drivers/net/ethernet/rocker/rocker.c Jim Davis
2014-12-04 17:36 ` [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig Andreas Ruprecht
2014-12-04 18:15 ` Jiri Pirko [this message]
2014-12-05 4:24 ` David Miller
2014-12-05 8:28 ` Andreas Ruprecht
2014-12-05 8:32 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204181548.GH1861@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=jim.epost@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mail@rupran$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox