From: Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public•gmane.org>
To: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public•gmane.org>
Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public•gmane.org>,
poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public•gmane.org,
Jonathan Corbet <corbet-T1hC0tSOHrs@public•gmane.org>,
LKML doc <linux-doc-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH v2] watchdog: omap_wdt: early_enable module parameter
Date: Tue, 30 Jun 2015 08:58:07 +0200 [thread overview]
Message-ID: <20150630065807.GA5645@spo001.leaseweb.nl> (raw)
In-Reply-To: <CAP=VYLr5wVMBdA76U0HKP2GTN07qiCkCTtBmFG5Z_bWE0QvT9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Paul,
> On Thu, Jun 25, 2015 at 9:46 AM, Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public•gmane.org> wrote:
> > On 06/25/2015 03:21 AM, poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public•gmane.org wrote:
> >>
> >> From: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public•gmane.org>
> >>
> >> Add a early_enable module parameter to the omap_wdt that starts the
> >> watchdog on module insertion. The default value is 0 which does not
> >> start the watchdog - which also does not change the behavior if the
> >> parameter is not given.
> >>
> >> Signed-off-by: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public•gmane.org>
> >
> >
> > Reviewed-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public•gmane.org>
>
> In case the info hasn't looped back around yet, this breaks the
> omap builds in linux-next:
>
> drivers/watchdog/omap_wdt.c:288:18: error: 'omap_wdt' undeclared
> (first use in this function)
>
> (Not sure how this could have ever worked as-is.)
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12452335/
>
> I see a patch has already been posted to arm-kernel but not
> Cc'd to all originally involved so figured I'd mention it.
It's fixed. The reason why we din't catch it was because of interference
with 'watchdog: omap: put struct watchdog_device into driver data'.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-06-30 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1435227711-29875-1-git-send-email-poeschel@lemonage.de>
[not found] ` <558C0634.9050802@roeck-us.net>
2015-06-30 5:56 ` [PATCH v2] watchdog: omap_wdt: early_enable module parameter Paul Gortmaker
[not found] ` <CAP=VYLr5wVMBdA76U0HKP2GTN07qiCkCTtBmFG5Z_bWE0QvT9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-30 6:58 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630065807.GA5645@spo001.leaseweb.nl \
--to=wim-iqzoog9ftrqzqb+pc5nmwq@public$(echo .)gmane.org \
--cc=corbet-T1hC0tSOHrs@public$(echo .)gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public$(echo .)gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public$(echo .)gmane.org \
--cc=poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox