* Re: [PATCH v2] watchdog: omap_wdt: early_enable module parameter
[not found] ` <558C0634.9050802@roeck-us.net>
@ 2015-06-30 5:56 ` Paul Gortmaker
[not found] ` <CAP=VYLr5wVMBdA76U0HKP2GTN07qiCkCTtBmFG5Z_bWE0QvT9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2015-06-30 5:56 UTC (permalink / raw)
To: Guenter Roeck
Cc: poeschel, wim, Jonathan Corbet, LKML doc, linux-watchdog, LKML,
linux-next@vger•kernel.org
On Thu, Jun 25, 2015 at 9:46 AM, Guenter Roeck <linux@roeck-us•net> wrote:
> On 06/25/2015 03:21 AM, poeschel@lemonage•de wrote:
>>
>> From: Lars Poeschel <poeschel@lemonage•de>
>>
>> Add a early_enable module parameter to the omap_wdt that starts the
>> watchdog on module insertion. The default value is 0 which does not
>> start the watchdog - which also does not change the behavior if the
>> parameter is not given.
>>
>> Signed-off-by: Lars Poeschel <poeschel@lemonage•de>
>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us•net>
In case the info hasn't looped back around yet, this breaks the
omap builds in linux-next:
drivers/watchdog/omap_wdt.c:288:18: error: 'omap_wdt' undeclared
(first use in this function)
(Not sure how this could have ever worked as-is.)
http://kisskb.ellerman.id.au/kisskb/buildresult/12452335/
I see a patch has already been posted to arm-kernel but not
Cc'd to all originally involved so figured I'd mention it.
Paul.
--
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] watchdog: omap_wdt: early_enable module parameter
[not found] ` <CAP=VYLr5wVMBdA76U0HKP2GTN07qiCkCTtBmFG5Z_bWE0QvT9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2015-06-30 6:58 ` Wim Van Sebroeck
0 siblings, 0 replies; 2+ messages in thread
From: Wim Van Sebroeck @ 2015-06-30 6:58 UTC (permalink / raw)
To: Paul Gortmaker
Cc: Guenter Roeck, poeschel-Xtl8qvBWbHwb1SvskN2V4Q, Jonathan Corbet,
LKML doc, linux-watchdog-u79uwXL29TY76Z2rM5mHXA, LKML,
linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Hi Paul,
> On Thu, Jun 25, 2015 at 9:46 AM, Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public•gmane.org> wrote:
> > On 06/25/2015 03:21 AM, poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public•gmane.org wrote:
> >>
> >> From: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public•gmane.org>
> >>
> >> Add a early_enable module parameter to the omap_wdt that starts the
> >> watchdog on module insertion. The default value is 0 which does not
> >> start the watchdog - which also does not change the behavior if the
> >> parameter is not given.
> >>
> >> Signed-off-by: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public•gmane.org>
> >
> >
> > Reviewed-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public•gmane.org>
>
> In case the info hasn't looped back around yet, this breaks the
> omap builds in linux-next:
>
> drivers/watchdog/omap_wdt.c:288:18: error: 'omap_wdt' undeclared
> (first use in this function)
>
> (Not sure how this could have ever worked as-is.)
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12452335/
>
> I see a patch has already been posted to arm-kernel but not
> Cc'd to all originally involved so figured I'd mention it.
It's fixed. The reason why we din't catch it was because of interference
with 'watchdog: omap: put struct watchdog_device into driver data'.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-30 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1435227711-29875-1-git-send-email-poeschel@lemonage.de>
[not found] ` <558C0634.9050802@roeck-us.net>
2015-06-30 5:56 ` [PATCH v2] watchdog: omap_wdt: early_enable module parameter Paul Gortmaker
[not found] ` <CAP=VYLr5wVMBdA76U0HKP2GTN07qiCkCTtBmFG5Z_bWE0QvT9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-30 6:58 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox