* next-20160208 perf build error "tests/bp_signal.c:106:47: error: declaration of ‘signal’ shadows a global declaration [-Werror=shadow]"
@ 2016-02-08 18:28 Vinson Lee
2016-02-11 22:21 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Vinson Lee @ 2016-02-08 18:28 UTC (permalink / raw)
To: linux-next
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Wang Nan,
Jiri Olsa
Hi.
I hit this perf build error with next-20160208 with GCC 4.6.
CC tests/bp_signal.o
tests/bp_signal.c: In function ‘__event’:
tests/bp_signal.c:106:47: error: declaration of ‘signal’ shadows a
global declaration [-Werror=shadow]
tests/bp_signal.c: In function ‘bp_event’:
tests/bp_signal.c:144:37: error: declaration of ‘signal’ shadows a
global declaration [-Werror=shadow]
tests/bp_signal.c: In function ‘wp_event’:
tests/bp_signal.c:149:37: error: declaration of ‘signal’ shadows a
global declaration [-Werror=shadow]
The build error is introduced with "perf test: Check environment
before start real BPF test".
commit 6a7d550e8b2eeb380ab85d9bc53571123b98345b
Author: Wang Nan <wangnan0@huawei•com>
Date: Mon Jan 25 09:55:53 2016 +0000
perf test: Check environment before start real BPF test
Copying perf to old kernel system results:
# perf test bpf
37: Test BPF filter :
37.1: Test basic BPF filtering : FAILED!
37.2: Test BPF prologue generation : Skip
However, in case when kernel doesn't support a test case it should
return 'Skip', 'FAILED!' should be reserved for kernel tests for when
the kernel supports a feature that then fails to work as advertised.
This patch checks environment before real testcase.
Signed-off-by: Wang Nan <wangnan0@huawei•com>
Suggested-by: Arnaldo Carvalho de Melo <acme@redhat•com>
Cc: Alexei Starovoitov <ast@kernel•org>
Cc: Brendan Gregg <brendan.d.gregg@gmail•com>
Cc: Daniel Borkmann <daniel@iogearbox•net>
Cc: He Kuang <hekuang@huawei•com>
Cc: Jiri Olsa <jolsa@kernel•org>
Cc: Li Zefan <lizefan@huawei•com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi•com>
Cc: Namhyung Kim <namhyung@kernel•org>
Cc: Peter Zijlstra <peterz@infradead•org>
Cc: Will Deacon <will.deacon@arm•com>
Cc: pi3orama@163•com
Link: http://lkml.kernel.org/r/1453715801-7732-7-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat•com>
Cheers,
Vinson
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: next-20160208 perf build error "tests/bp_signal.c:106:47: error: declaration of ‘signal’ shadows a global declaration [-Werror=shadow]" 2016-02-08 18:28 next-20160208 perf build error "tests/bp_signal.c:106:47: error: declaration of ‘signal’ shadows a global declaration [-Werror=shadow]" Vinson Lee @ 2016-02-11 22:21 ` Arnaldo Carvalho de Melo 2016-02-12 21:40 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 3+ messages in thread From: Arnaldo Carvalho de Melo @ 2016-02-11 22:21 UTC (permalink / raw) To: Vinson Lee; +Cc: linux-next, Peter Zijlstra, Ingo Molnar, Wang Nan, Jiri Olsa Em Mon, Feb 08, 2016 at 10:28:53AM -0800, Vinson Lee escreveu: > Hi. > > I hit this perf build error with next-20160208 with GCC 4.6. I try to test on a rhel6 vm from time to time, need to do it using docker or something, thanks for the report, but can you please send a proper patch, with a: Fixes: 6a7d550e8b2e ("perf test: Check environment before start real BPF test") Line, signed-off, etc? Thanks, - Arnaldo > CC tests/bp_signal.o > tests/bp_signal.c: In function ‘__event’: > tests/bp_signal.c:106:47: error: declaration of ‘signal’ shadows a > global declaration [-Werror=shadow] > tests/bp_signal.c: In function ‘bp_event’: > tests/bp_signal.c:144:37: error: declaration of ‘signal’ shadows a > global declaration [-Werror=shadow] > tests/bp_signal.c: In function ‘wp_event’: > tests/bp_signal.c:149:37: error: declaration of ‘signal’ shadows a > global declaration [-Werror=shadow] > > The build error is introduced with "perf test: Check environment > before start real BPF test". > > commit 6a7d550e8b2eeb380ab85d9bc53571123b98345b > Author: Wang Nan <wangnan0@huawei•com> > Date: Mon Jan 25 09:55:53 2016 +0000 > > perf test: Check environment before start real BPF test > > Copying perf to old kernel system results: > > # perf test bpf > 37: Test BPF filter : > 37.1: Test basic BPF filtering : FAILED! > 37.2: Test BPF prologue generation : Skip > > However, in case when kernel doesn't support a test case it should > return 'Skip', 'FAILED!' should be reserved for kernel tests for when > the kernel supports a feature that then fails to work as advertised. > > This patch checks environment before real testcase. > > Signed-off-by: Wang Nan <wangnan0@huawei•com> > Suggested-by: Arnaldo Carvalho de Melo <acme@redhat•com> > Cc: Alexei Starovoitov <ast@kernel•org> > Cc: Brendan Gregg <brendan.d.gregg@gmail•com> > Cc: Daniel Borkmann <daniel@iogearbox•net> > Cc: He Kuang <hekuang@huawei•com> > Cc: Jiri Olsa <jolsa@kernel•org> > Cc: Li Zefan <lizefan@huawei•com> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi•com> > Cc: Namhyung Kim <namhyung@kernel•org> > Cc: Peter Zijlstra <peterz@infradead•org> > Cc: Will Deacon <will.deacon@arm•com> > Cc: pi3orama@163•com > Link: http://lkml.kernel.org/r/1453715801-7732-7-git-send-email-wangnan0@huawei.com > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat•com> > > Cheers, > Vinson ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: next-20160208 perf build error "tests/bp_signal.c:106:47: error: declaration of ‘signal’ shadows a global declaration [-Werror=shadow]" 2016-02-11 22:21 ` Arnaldo Carvalho de Melo @ 2016-02-12 21:40 ` Arnaldo Carvalho de Melo 0 siblings, 0 replies; 3+ messages in thread From: Arnaldo Carvalho de Melo @ 2016-02-12 21:40 UTC (permalink / raw) To: Vinson Lee; +Cc: linux-next, Peter Zijlstra, Ingo Molnar, Wang Nan, Jiri Olsa Em Thu, Feb 11, 2016 at 07:21:21PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Feb 08, 2016 at 10:28:53AM -0800, Vinson Lee escreveu: > > I hit this perf build error with next-20160208 with GCC 4.6. > I try to test on a rhel6 vm from time to time, need to do it using > docker or something, thanks for the report, but can you please send a > proper patch, with a: > > Fixes: 6a7d550e8b2e ("perf test: Check environment before start real BPF test") > > Line, signed-off, etc? Do it next time please, I did this time, when testing other changes on my rhel6.7 vm, its in my perf/core branch, Thanks, - arnaldo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-12 21:40 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-08 18:28 next-20160208 perf build error "tests/bp_signal.c:106:47: error: declaration of ‘signal’ shadows a global declaration [-Werror=shadow]" Vinson Lee 2016-02-11 22:21 ` Arnaldo Carvalho de Melo 2016-02-12 21:40 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox